== Series Details == Series: series starting with [01/28] drm/i915: Wait for a moment before forcibly resetting the device URL : https://patchwork.freedesktop.org/series/55819/ State : warning == Summary == $ dim checkpatch origin/drm-tip d1a18083cdf2 drm/i915: Wait for a moment before forcibly resetting the device 5ad153d0bd5c drm/i915: Rename execlists->queue_priority to preempt_priority_hint 40c5003bdadf drm/i915/execlists: Suppress preempting self -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: value as it may match a second preemption request within the same time period -:34: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context")' #34: References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context") -:310: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15) #310: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:321: + if (USES_GUC_SUBMISSION(i915)) + return 0; /* presume black blox */ -:311: WARNING:TABSTOP: Statements should start on a tabstop #311: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:322: + return 0; /* presume black blox */ total: 1 errors, 3 warnings, 0 checks, 331 lines checked df9f13ca4ec4 drm/i915/execlists: Suppress redundant preemption 7130ed077421 drm/i915/selftests: Exercise some AB...BA preemption chains 86ccc8e3bbae drm/i915: Stop tracking MRU activity on VMA c13adc525292 drm/i915: Pull VM lists under the VM mutex. 14422ca9a152 drm/i915: Move vma lookup to its own lock -:161: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t #161: FILE: drivers/gpu/drm/i915/i915_gem_object.h:94: + struct spinlock lock; total: 0 errors, 1 warnings, 0 checks, 290 lines checked 4ee1baed5b4f drm/i915: Always allocate an object/vma for the HWSP db09c28b2b22 drm/i915: Add timeline barrier support 25fd0b43e01d drm/i915: Move list of timelines under its own lock 7668d538487a drm/i915: Introduce concept of per-timeline (context) HWSP ea85f8149c30 drm/i915: Enlarge vma->pin_count 0bd928489b01 drm/i915: Allocate a status page for each timeline acd492aca17a drm/i915: Share per-timeline HWSP using a slab suballocator -:85: CHECK:SPACING: No space is necessary after a cast #85: FILE: drivers/gpu/drm/i915/i915_timeline.c:49: + BUILD_BUG_ON(BITS_PER_TYPE(u64) * CACHELINE_BYTES > PAGE_SIZE); total: 0 errors, 0 warnings, 1 checks, 408 lines checked 986a556f530d drm/i915: Track the context's seqno in its own timeline HWSP 054cafc5f0a9 drm/i915: Track active timelines fc685c80d89a drm/i915: Identify active requests e1f1d9e2cffc drm/i915: Remove the intel_engine_notify tracepoint f3a2f67ac514 drm/i915: Replace global breadcrumbs with per-context interrupt tracking -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #18: Before commit 688e6c725816, the solution was simple. Every client -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #21: 688e6c725816 introduced an rbtree so that only the earliest waiter on -:56: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #56: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:56: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #56: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:2194: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name #2194: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2194: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name #2194: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2220: WARNING:LINE_SPACING: Missing a blank line after declarations #2220: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:284: + struct i915_request **requests; + I915_RND_STATE(prng); -:2652: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2652: deleted file mode 100644 total: 3 errors, 5 warnings, 0 checks, 2586 lines checked 65852a23b056 drm/i915: Drop fake breadcrumb irq c1f917a45d01 drm/i915: Generalise GPU activity tracking -:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 -:36: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #36: FILE: drivers/gpu/drm/i915/i915_active.c:1: +/* -:268: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #268: FILE: drivers/gpu/drm/i915/i915_active.h:1: +/* -:673: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #673: FILE: drivers/gpu/drm/i915/selftests/i915_active.c:1: +/* total: 0 errors, 4 warnings, 0 checks, 777 lines checked f2e9ea6da317 drm/i915: Allocate active tracking nodes from a slabcache 45f78b1208c6 drm/i915: Pull i915_gem_active into the i915_active family -:689: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #689: FILE: drivers/gpu/drm/i915/i915_gem_fence_reg.c:227: + ret = i915_active_request_retire(&vma->last_fence, &vma->obj->base.dev->struct_mutex); -:698: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #698: FILE: drivers/gpu/drm/i915/i915_gem_fence_reg.c:236: + ret = i915_active_request_retire(&old->last_fence, &old->obj->base.dev->struct_mutex); -:1405: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1405: FILE: drivers/gpu/drm/i915/i915_vma.c:991: + ret = i915_active_request_retire(&vma->last_fence, + &vma->vm->i915->drm.struct_mutex); total: 0 errors, 0 warnings, 3 checks, 1378 lines checked 27f6d4f4cd1c drm/i915: Keep timeline HWSP allocated until the system is idle 14aaf2f6c78e drm/i915/execlists: Refactor out can_merge_rq() e5a1d3d08737 drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+ -:310: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #310: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109: +#define MI_SEMAPHORE_SAD_GT_SDD (0<<12) ^ -:312: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #312: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111: +#define MI_SEMAPHORE_SAD_LT_SDD (2<<12) ^ -:313: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #313: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112: +#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12) ^ -:314: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #314: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113: +#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12) ^ -:315: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #315: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114: +#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12) ^ total: 0 errors, 0 warnings, 5 checks, 274 lines checked c24e37a562af drm/i915: Prioritise non-busywait semaphore workloads _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
