Quoting Tvrtko Ursulin (2019-01-24 11:59:42) > +static int > +__read_slice_count(struct drm_i915_private *i915, > + struct i915_gem_context *ctx, > + struct intel_engine_cs *engine, > + struct drm_i915_gem_object *obj, > + struct igt_spinner *spin, > + u32 *rpcs) > +{ > + struct i915_request *rq = NULL; > + u32 s_mask, s_shift; > + unsigned int cnt; > + u32 *buf, val; > + long ret; > + > + ret = emit_rpcs_query(obj, ctx, engine, &rq); > + if (ret) > + return ret; > + > + if (spin) > + igt_spinner_end(spin); > + > + ret = i915_request_wait(rq, I915_WAIT_LOCKED, MAX_SCHEDULE_TIMEOUT); > + if (ret < 0) > + return ret; > + > + i915_request_put(rq); put before ret and I'm happy. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx