On Tue, Jan 22, 2019 at 09:37:02PM +0000, Chris Wilson wrote:
Quoting Lucas De Marchi (2019-01-22 21:33:25)
On Tue, Jan 22, 2019 at 6:32 AM Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>
> Quoting Lucas De Marchi (2019-01-22 05:12:24)
> > Let's use a macro to make tables smaller and at the same time allow us
> > to add fields that apply to all entries in future.
> >
> > For the sake of readability, I'm calling an exception on 80 chars limit.
> > Lines are aligned for easy comparison of the entry values.
>
> > + MOCS_ENTRY(I915_MOCS_UNCACHED, LE_1_UC | LE_TC_2_LLC_ELLC, \
> > + L3_1_UC), \
>
> MOCS_ENTRY(I915_MOCS_UNCACHED,
> LE_1_UC | LE_TC_2_LLC_ELLC, L3_1_UC), \
My intention was to split the lines for each *value*, so it's easy to
see what control_value vs l3cc_value is set to
(too difficult to spot mistakes on adding a comma rather than a |).
But I'm not strongly against your version, so I'll switch to that.
Have another new line :)
Because you are right as I confused that \ for a |.
MOCS_ENTRY(I915_MOCS_UNCACHED, \
LE_1_UC | LE_TC_2_LLC_ELLC, \
L3_1_UC), \
ok. The Ice Lake table is huge (see last patch) and this will mandate 3
lines per entry, but at least it will be clear.
Lucas De Marchi
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
