== Series Details == Series: series starting with [01/34] drm/i915/execlists: Mark up priority boost on preemption (rev2) URL : https://patchwork.freedesktop.org/series/55528/ State : warning == Summary == $ dim checkpatch origin/drm-tip a3cfcd69db36 drm/i915/execlists: Mark up priority boost on preemption 10d459a62e38 drm/i915/execlists: Suppress preempting self -:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context") -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context")' #18: References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context") total: 1 errors, 1 warnings, 0 checks, 92 lines checked dcf4a4c2fe84 drm/i915: Make all GPU resets atomic -:24: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #24: FILE: drivers/gpu/drm/i915/i915_reset.c:147: + udelay(50); -:30: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #30: FILE: drivers/gpu/drm/i915/i915_reset.c:152: + udelay(50); total: 0 errors, 0 warnings, 2 checks, 111 lines checked 4a03a5667d92 drm/i915/guc: Disable global reset 3476465681a2 drm/i915: Remove GPU reset dependence on struct_mutex -:878: WARNING:MEMORY_BARRIER: memory barrier without comment #878: FILE: drivers/gpu/drm/i915/i915_reset.c:692: + smp_store_mb(i915->gpu_error.restart, NULL); -:1031: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1031: FILE: drivers/gpu/drm/i915/i915_reset.c:920: +#if 0 -:1302: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #1302: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:35: + bool wedged:1; -:1303: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #1303: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:36: + bool stalled:1; total: 0 errors, 4 warnings, 0 checks, 1729 lines checked 12191ab875dc drm/i915/selftests: Trim struct_mutex duration for set-wedged selftest 00a3c0fb6b45 drm/i915: Issue engine resets onto idle engines 399e8162cc6e drm/i915: Stop tracking MRU activity on VMA efdf8e2689a2 drm/i915: Pull VM lists under the VM mutex. a1a65ee34602 drm/i915: Move vma lookup to its own lock -:161: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t #161: FILE: drivers/gpu/drm/i915/i915_gem_object.h:94: + struct spinlock lock; total: 0 errors, 1 warnings, 0 checks, 290 lines checked da04ace11678 drm/i915: Always allocate an object/vma for the HWSP a1911268d4ef drm/i915: Move list of timelines under its own lock 951f23aae0b5 drm/i915: Introduce concept of per-timeline (context) HWSP 095b07e9d68d drm/i915: Enlarge vma->pin_count 0747da7f8236 drm/i915: Allocate a status page for each timeline e19bdb2707c7 drm/i915: Share per-timeline HWSP using a slab suballocator -:80: CHECK:SPACING: No space is necessary after a cast #80: FILE: drivers/gpu/drm/i915/i915_timeline.c:44: + BUILD_BUG_ON(BITS_PER_TYPE(u64) * CACHELINE_BYTES > PAGE_SIZE); total: 0 errors, 0 warnings, 1 checks, 416 lines checked e996dc446d99 drm/i915: Track the context's seqno in its own timeline HWSP -:225: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #225: FILE: drivers/gpu/drm/i915/intel_lrc.c:2073: } +static const int gen8_emit_breadcrumb_sz = 10 + WA_TAIL_DWORDS; -:256: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #256: FILE: drivers/gpu/drm/i915/intel_lrc.c:2099: } +static const int gen8_emit_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS; -:282: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #282: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:344: } +static const int gen6_rcs_emit_breadcrumb_sz = 18; -:305: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #305: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:451: } +static const int gen7_rcs_emit_breadcrumb_sz = 10; -:326: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #326: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:469: } +static const int gen6_xcs_emit_breadcrumb_sz = 8; -:354: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #354: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:499: } +static const int gen7_xcs_emit_breadcrumb_sz = 10 + GEN7_XCS_WA * 3; -:404: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #404: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:945: } +static const int i9xx_emit_breadcrumb_sz = 8; -:432: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #432: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:973: } +static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 6; total: 0 errors, 0 warnings, 8 checks, 471 lines checked de57462d995b drm/i915: Track active timelines c16ba49bd4fb drm/i915: Identify active requests -:196: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #196: FILE: drivers/gpu/drm/i915/intel_lrc.c:2101: } +static const int gen8_emit_fini_breadcrumb_sz = 10 + WA_TAIL_DWORDS; -:208: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #208: FILE: drivers/gpu/drm/i915/intel_lrc.c:2127: } +static const int gen8_emit_fini_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS; total: 0 errors, 0 warnings, 2 checks, 278 lines checked 4ceaaf382a3a drm/i915: Remove the intel_engine_notify tracepoint 779d269c1c4a drm/i915: Replace global breadcrumbs with per-context interrupt tracking -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #18: Before commit 688e6c725816, the solution was simple. Every client waking -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #21: 688e6c725816 introduced an rbtree so that only the earliest waiter on -:53: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #53: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:53: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #53: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:2150: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name #2150: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2150: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name #2150: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2173: WARNING:LINE_SPACING: Missing a blank line after declarations #2173: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:281: + struct i915_request **requests; + I915_RND_STATE(prng); -:2603: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2603: deleted file mode 100644 total: 3 errors, 5 warnings, 0 checks, 2549 lines checked 0e4b16cc65d1 drm/i915: Drop fake breadcrumb irq 6f083f333e1b drm/i915: Keep timeline HWSP allocated until the system is idle eca588a4e40b drm/i915/execlists: Refactor out can_merge_rq() 4ae5953452b9 drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+ -:296: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #296: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109: +#define MI_SEMAPHORE_SAD_GT_SDD (0<<12) ^ -:298: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #298: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111: +#define MI_SEMAPHORE_SAD_LT_SDD (2<<12) ^ -:299: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #299: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112: +#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12) ^ -:300: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #300: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113: +#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12) ^ -:301: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #301: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114: +#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12) ^ total: 0 errors, 0 warnings, 5 checks, 259 lines checked cb287c2a9e41 drm/i915: Prioritise non-busywait semaphore workloads 39186577611a drm/i915: Replace global_seqno with a hangcheck heartbeat seqno -:122: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #122: FILE: drivers/gpu/drm/i915/intel_lrc.c:2131: } +static const int gen8_emit_fini_breadcrumb_sz = 14 + WA_TAIL_DWORDS; -:143: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #143: FILE: drivers/gpu/drm/i915/intel_lrc.c:2162: } +static const int gen8_emit_fini_breadcrumb_rcs_sz = 20 + WA_TAIL_DWORDS; -:170: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #170: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:472: } +static const int gen6_xcs_emit_breadcrumb_sz = 10; -:195: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #195: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:507: } +static const int gen7_xcs_emit_breadcrumb_sz = 14 + GEN7_XCS_WA * 3; -:218: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #218: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:958: } +static const int i9xx_emit_breadcrumb_sz = 12; -:243: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #243: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:989: } +static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 8; total: 0 errors, 0 warnings, 6 checks, 236 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
