== Series Details == Series: series starting with [01/34] drm/i915/execlists: Mark up priority boost on preemption URL : https://patchwork.freedesktop.org/series/55528/ State : warning == Summary == $ dim checkpatch origin/drm-tip 096d4f120d3e drm/i915/execlists: Mark up priority boost on preemption 85c9694f46a4 drm/i915/execlists: Suppress preempting self -:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context") -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context")' #18: References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the current context") total: 1 errors, 1 warnings, 0 checks, 92 lines checked 58648274db42 drm/i915: Show all active engines on hangcheck fd236ee5650b drm/i915/selftests: Refactor common live_test framework -:435: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #435: new file mode 100644 -:440: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #440: FILE: drivers/gpu/drm/i915/selftests/igt_live_test.c:1: +/* -:531: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #531: FILE: drivers/gpu/drm/i915/selftests/igt_live_test.h:1: +/* total: 0 errors, 3 warnings, 0 checks, 496 lines checked 424a90dd6d68 drm/i915/selftests: Track evict objects explicitly -:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #12: References: 71fc448c1aaf ("drm/i915/selftests: Make evict tolerant of foreign objects") -:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 71fc448c1aaf ("drm/i915/selftests: Make evict tolerant of foreign objects")' #12: References: 71fc448c1aaf ("drm/i915/selftests: Make evict tolerant of foreign objects") total: 1 errors, 1 warnings, 0 checks, 256 lines checked 525322709fa3 drm/i915/selftests: Create a clean GGTT for vma/gtt selftesting -:393: WARNING:LONG_LINE: line over 100 characters #393: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:265: + VALID(0, PIN_GLOBAL | PIN_MAPPABLE | PIN_OFFSET_FIXED | (ggtt->mappable_end - 4096)), -:416: WARNING:LONG_LINE: line over 100 characters #416: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:280: + INVALID(8192, PIN_GLOBAL | PIN_MAPPABLE | PIN_OFFSET_FIXED | (ggtt->mappable_end - 4096)), -:435: WARNING:LONG_LINE: line over 100 characters #435: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:294: + NOSPACE(8192, PIN_GLOBAL | PIN_MAPPABLE | PIN_OFFSET_BIAS | (ggtt->mappable_end - 4096)), total: 0 errors, 3 warnings, 0 checks, 520 lines checked 82cdc06b4a39 drm/i915: Refactor out intel_context_init() 912b47059d6e drm/i915: Make all GPU resets atomic -:24: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #24: FILE: drivers/gpu/drm/i915/i915_reset.c:147: + udelay(50); -:30: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #30: FILE: drivers/gpu/drm/i915/i915_reset.c:152: + udelay(50); total: 0 errors, 0 warnings, 2 checks, 111 lines checked 00695a093e1f drm/i915/guc: Disable global reset f6dd5893f7b8 drm/i915: Remove GPU reset dependence on struct_mutex -:878: WARNING:MEMORY_BARRIER: memory barrier without comment #878: FILE: drivers/gpu/drm/i915/i915_reset.c:692: + smp_store_mb(i915->gpu_error.restart, NULL); -:1031: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1031: FILE: drivers/gpu/drm/i915/i915_reset.c:920: +#if 0 -:1302: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #1302: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:35: + bool wedged:1; -:1303: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #1303: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:36: + bool stalled:1; total: 0 errors, 4 warnings, 0 checks, 1729 lines checked faf113b5e213 drm/i915/selftests: Trim struct_mutex duration for set-wedged selftest 789901576adf drm/i915: Issue engine resets onto idle engines 4f90b7cb5b32 drm/i915: Stop tracking MRU activity on VMA 3e5e7f676feb drm/i915: Pull VM lists under the VM mutex. ef26f0a3b3db drm/i915: Move vma lookup to its own lock -:161: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t #161: FILE: drivers/gpu/drm/i915/i915_gem_object.h:94: + struct spinlock lock; total: 0 errors, 1 warnings, 0 checks, 290 lines checked f2c29c8ca52c drm/i915: Always allocate an object/vma for the HWSP 25604144be52 drm/i915: Move list of timelines under its own lock b048cc2c6473 drm/i915/selftests: Use common mock_engine::advance 744111bb6c5e drm/i915: Tidy common test_bit probing of i915_request->fence.flags e817b79ab8b6 drm/i915: Introduce concept of per-timeline (context) HWSP d2f9c373370e drm/i915: Enlarge vma->pin_count 74aa9e1fc5b3 drm/i915: Allocate a status page for each timeline 5f0f0c9295ff drm/i915: Share per-timeline HWSP using a slab suballocator -:79: CHECK:SPACING: No space is necessary after a cast #79: FILE: drivers/gpu/drm/i915/i915_timeline.c:44: + BUILD_BUG_ON(BITS_PER_TYPE(u64) * CACHELINE_BYTES > PAGE_SIZE); total: 0 errors, 0 warnings, 1 checks, 416 lines checked daf8d943452d drm/i915: Track the context's seqno in its own timeline HWSP -:224: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #224: FILE: drivers/gpu/drm/i915/intel_lrc.c:2073: } +static const int gen8_emit_breadcrumb_sz = 10 + WA_TAIL_DWORDS; -:255: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #255: FILE: drivers/gpu/drm/i915/intel_lrc.c:2099: } +static const int gen8_emit_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS; -:281: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #281: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:344: } +static const int gen6_rcs_emit_breadcrumb_sz = 18; -:304: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #304: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:451: } +static const int gen7_rcs_emit_breadcrumb_sz = 10; -:325: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #325: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:469: } +static const int gen6_xcs_emit_breadcrumb_sz = 8; -:353: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #353: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:499: } +static const int gen7_xcs_emit_breadcrumb_sz = 10 + GEN7_XCS_WA * 3; -:403: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #403: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:945: } +static const int i9xx_emit_breadcrumb_sz = 8; -:431: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #431: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:973: } +static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 6; total: 0 errors, 0 warnings, 8 checks, 471 lines checked 4daf132957fc drm/i915: Track active timelines 6671fcc878bd drm/i915: Identify active requests -:195: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #195: FILE: drivers/gpu/drm/i915/intel_lrc.c:2101: } +static const int gen8_emit_fini_breadcrumb_sz = 10 + WA_TAIL_DWORDS; -:207: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #207: FILE: drivers/gpu/drm/i915/intel_lrc.c:2127: } +static const int gen8_emit_fini_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS; total: 0 errors, 0 warnings, 2 checks, 278 lines checked 063e9cd8eb0a drm/i915: Remove the intel_engine_notify tracepoint 9534b50448fe drm/i915: Replace global breadcrumbs with per-context interrupt tracking -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #18: Before commit 688e6c725816, the solution was simple. Every client waking -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #21: 688e6c725816 introduced an rbtree so that only the earliest waiter on -:49: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #49: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:49: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #49: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:1997: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name #1997: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:1997: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name #1997: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2021: WARNING:LINE_SPACING: Missing a blank line after declarations #2021: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:282: + struct i915_request **requests; + I915_RND_STATE(prng); -:2428: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2428: deleted file mode 100644 total: 3 errors, 5 warnings, 0 checks, 2387 lines checked 09c15d6b8399 drm/i915: Drop fake breadcrumb irq 6a7f5b9d1dfc drm/i915: Keep timeline HWSP allocated until the system is idle 4c26f95d5c56 drm/i915/execlists: Refactor out can_merge_rq() f557fb2f2149 drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+ -:296: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #296: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109: +#define MI_SEMAPHORE_SAD_GT_SDD (0<<12) ^ -:298: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #298: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111: +#define MI_SEMAPHORE_SAD_LT_SDD (2<<12) ^ -:299: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #299: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112: +#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12) ^ -:300: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #300: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113: +#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12) ^ -:301: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #301: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114: +#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12) ^ total: 0 errors, 0 warnings, 5 checks, 259 lines checked 2befa074162f drm/i915: Prioritise non-busywait semaphore workloads 6cedf9409751 drm/i915: Replace global_seqno with a hangcheck heartbeat seqno -:122: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #122: FILE: drivers/gpu/drm/i915/intel_lrc.c:2131: } +static const int gen8_emit_fini_breadcrumb_sz = 14 + WA_TAIL_DWORDS; -:143: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #143: FILE: drivers/gpu/drm/i915/intel_lrc.c:2162: } +static const int gen8_emit_fini_breadcrumb_rcs_sz = 20 + WA_TAIL_DWORDS; -:170: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #170: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:472: } +static const int gen6_xcs_emit_breadcrumb_sz = 10; -:195: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #195: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:507: } +static const int gen7_xcs_emit_breadcrumb_sz = 14 + GEN7_XCS_WA * 3; -:218: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #218: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:958: } +static const int i9xx_emit_breadcrumb_sz = 12; -:243: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #243: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:989: } +static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 8; total: 0 errors, 0 warnings, 6 checks, 236 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
