== Series Details == Series: series starting with [01/23] drm/i915: Make all GPU resets atomic URL : https://patchwork.freedesktop.org/series/55365/ State : warning == Summary == $ dim checkpatch origin/drm-tip cc34d0c113bf drm/i915: Make all GPU resets atomic -:23: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #23: FILE: drivers/gpu/drm/i915/i915_reset.c:147: + udelay(50); -:29: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #29: FILE: drivers/gpu/drm/i915/i915_reset.c:152: + udelay(50); total: 0 errors, 0 warnings, 2 checks, 121 lines checked 84c5d840f63e drm/i915/guc: Disable global reset 13c95ff25011 drm/i915: Remove GPU reset dependence on struct_mutex -:616: WARNING:MEMORY_BARRIER: memory barrier without comment #616: FILE: drivers/gpu/drm/i915/i915_reset.c:692: + smp_store_mb(i915->gpu_error.restart, NULL); -:769: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #769: FILE: drivers/gpu/drm/i915/i915_reset.c:920: +#if 0 total: 0 errors, 2 warnings, 0 checks, 1395 lines checked b126705eb583 drm/i915/selftests: Trim struct_mutex duration for set-wedged selftest 9c242ce79a77 drm/i915: Issue engine resets onto idle engines 941079fbcd79 drm/i915: Stop tracking MRU activity on VMA b590cd93b877 drm/i915: Pull VM lists under the VM mutex. 1b8241711cd3 drm/i915: Move vma lookup to its own lock -:157: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t #157: FILE: drivers/gpu/drm/i915/i915_gem_object.h:94: + struct spinlock lock; total: 0 errors, 1 warnings, 0 checks, 284 lines checked 178df8680efe drm/i915: Use b->irq_enable() as predicate for mock engine -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")' #6: Since commit d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling") -:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")' #10: References: d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling") total: 2 errors, 0 warnings, 0 checks, 111 lines checked a6cd7e980da3 drm/i915/selftests: Allocate mock ring/timeline per context e64538758ef8 drm/i915/selftests: Make evict tolerant of foreign objects a9fb042af3e7 drm/i915: Always allocate an object/vma for the HWSP 4faf687777c5 drm/i915: Move list of timelines under its own lock fb705705e39d drm/i915: Introduce concept of per-timeline (context) HWSP 722338216230 drm/i915: Enlarge vma->pin_count 90c17ef7381e drm/i915: Allocate a status page for each timeline 9a2c0d841b87 drm/i915: Share per-timeline HWSP using a slab suballocator 590309e71727 drm/i915: Keep all partially allocated HWSP on a freelist 97e2101df0fe drm/i915: Track the context's seqno in its own timeline HWSP -:170: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #170: FILE: drivers/gpu/drm/i915/intel_lrc.c:2042: } +static const int gen8_emit_breadcrumb_sz = 10 + WA_TAIL_DWORDS; -:201: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #201: FILE: drivers/gpu/drm/i915/intel_lrc.c:2068: } +static const int gen8_emit_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS; -:227: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #227: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:343: } +static const int gen6_rcs_emit_breadcrumb_sz = 18; -:250: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #250: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:450: } +static const int gen7_rcs_emit_breadcrumb_sz = 10; -:271: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #271: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:468: } +static const int gen6_xcs_emit_breadcrumb_sz = 8; -:299: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #299: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:498: } +static const int gen7_xcs_emit_breadcrumb_sz = 10 + GEN7_XCS_WA * 3; -:351: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #351: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:944: } +static const int i9xx_emit_breadcrumb_sz = 8; -:379: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #379: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:972: } +static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 6; total: 0 errors, 0 warnings, 8 checks, 397 lines checked 22e584a722b8 drm/i915: Identify active requests f4d10d8a497c drm/i915: Remove the intel_engine_notify tracepoint 2c07c68932af drm/i915: Replace global breadcrumbs with per-context interrupt tracking -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #18: Before commit 688e6c725816, the solution was simple. Every client waking -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #21: 688e6c725816 introduced an rbtree so that only the earliest waiter on -:49: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #49: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:49: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")' #49: References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd") -:2012: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name #2012: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:257: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2012: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name #2012: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:257: + struct i915_request *(*request_alloc)(struct i915_gem_context *, -:2036: WARNING:LINE_SPACING: Missing a blank line after declarations #2036: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:281: + struct i915_request **requests; + I915_RND_STATE(prng); -:2443: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2443: deleted file mode 100644 total: 3 errors, 5 warnings, 0 checks, 2428 lines checked f7e648e4bba8 drm/i915: Drop fake breadcrumb irq _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
