On Wed, 16 Jan 2019, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Wed, Jan 16, 2019 at 11:15:18AM +0200, Jani Nikula wrote: >> Hi all - >> >> I haven't cared all that much about using C99 fixed size types (uint32_t >> etc.) in the driver in addition to kernel types, as long as only one or >> the other is used in the same struct/function/file. But the increasing >> mixed use crossed some OCD threshold the other day. It gets ugly, and >> sets a precedent that mixed use is fine. >> >> Let's switch to kernel types exclusively, shall we? >> >> Each path in the series is independent of the others, and it's mostly >> one patch per file, apart from the first patch which gathers all the >> isolated uses into one patch. I've tried to order the series from least >> to most likely to cause conflicts with in-flight work per gut feeling. >> >> Please holler if you think some of these patches need to wait for some >> other, more important stuff to land first. This was mostly scripted, >> with a few manual edits on top, so pretty quick to redo on top later. >> >> After most of these have landed, I intend to drop PREFER_KERNEL_TYPES >> from the checkpatch ignore list, and enforce. > > Did a really quick scan through and the pattern matcher in the > brain didn't complain, so seems good enough to me. > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Thanks for the reviews Chris, Ville & José! I pushed the the patches listed below for starters. Started small. While I took care with the r-b's, I failed to record the acks from Chris and Tvrtko. :( Apologies. BR, Jani. Pushed now: >> drm/i915: small isolated c99 types to kernel types switch >> drm/i915/crt: switch to kernel types >> drm/i915/lspcon: switch to kernel types >> drm/i915/debugfs: switch to kernel types >> drm/i915/irq: switch to kernel types >> drm/i915/cdclk: switch to kernel types >> drm/i915/dpll_mgr: switch to kernel types >> drm/i915/dp: switch to kernel types >> drm/i915/sprite: switch to kernel types -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
