✗ Fi.CI.CHECKPATCH: warning for drm/i915: Pull all the reset functionality together into i915_reset.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: Pull all the reset functionality together into i915_reset.c
URL   : https://patchwork.freedesktop.org/series/55308/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
01c7b5cb9d1a drm/i915: Pull all the reset functionality together into i915_reset.c
-:1090: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1090: 
new file mode 100644

-:1095: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1095: FILE: drivers/gpu/drm/i915/i915_reset.c:1:
+/*

-:1239: WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
#1239: FILE: drivers/gpu/drm/i915/i915_reset.c:145:
+	/* Assert reset for at least 20 usec, and wait for acknowledgement. */

-:1964: WARNING:MEMORY_BARRIER: memory barrier without comment
#1964: FILE: drivers/gpu/drm/i915/i915_reset.c:870:
+	smp_mb__before_atomic();

-:2263: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2263: FILE: drivers/gpu/drm/i915/i915_reset.c:1169:
+	char *error_event[] = { I915_ERROR_UEVENT "=1", NULL };

-:2264: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2264: FILE: drivers/gpu/drm/i915/i915_reset.c:1170:
+	char *reset_event[] = { I915_RESET_UEVENT "=1", NULL };

-:2265: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2265: FILE: drivers/gpu/drm/i915/i915_reset.c:1171:
+	char *reset_done_event[] = { I915_ERROR_UEVENT "=0", NULL };

-:2490: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2490: FILE: drivers/gpu/drm/i915/i915_reset.h:1:
+/*

-:2540: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects?
#2540: FILE: drivers/gpu/drm/i915/i915_reset.h:51:
+#define i915_wedge_on_timeout(W, DEV, TIMEOUT)				\
+	for (__i915_init_wedge((W), (DEV), (TIMEOUT), __func__);	\
+	     (W)->i915;							\
+	     __i915_fini_wedge((W)))

total: 0 errors, 8 warnings, 1 checks, 3113 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux