== Series Details == Series: series starting with [01/21] drm/i915: Track all held rpm wakerefs URL : https://patchwork.freedesktop.org/series/54986/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7870145b7f82 drm/i915: Track all held rpm wakerefs -:131: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #131: FILE: drivers/gpu/drm/i915/i915_drv.h:1170: + spinlock_t lock; total: 0 errors, 0 warnings, 1 checks, 639 lines checked 954a33b45c7d drm/i915: Markup paired operations on wakerefs -:371: WARNING:NEW_TYPEDEFS: do not add new typedefs #371: FILE: drivers/gpu/drm/i915/i915_drv.h:134: +typedef depot_stack_handle_t intel_wakeref_t; total: 0 errors, 1 warnings, 0 checks, 1166 lines checked 58ba2feb0515 drm/i915: Track GT wakeref a646944f6422 drm/i915: Track the rpm wakerefs for error handling a9d5508ffe7b drm/i915: Mark up sysfs with rpm wakeref tracking 643ff3ef2e75 drm/i915: Mark up debugfs with rpm wakeref tracking 43e91ef6865e drm/i915/perf: Track the rpm wakeref cd2cb400338c drm/i915/pmu: Track rpm wakeref dbc84b458d63 drm/i915/guc: Track the rpm wakeref d475d5434be3 drm/i915/gem: Track the rpm wakerefs d30d0a3e3993 drm/i915/fb: Track rpm wakerefs 1b677042aa6e drm/i915/hotplug: Track temporary rpm wakeref 632413ce6bfc drm/i915/panel: Track temporary rpm wakeref f9b85ebc3896 drm/i915/selftests: Mark up rpm wakerefs 8ecf35c401ff drm/i915: Syntatic sugar for using intel_runtime_pm -:513: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #513: FILE: drivers/gpu/drm/i915/intel_drv.h:2190: +#define with_intel_runtime_pm(i915, wf) \ + for ((wf) = intel_runtime_pm_get(i915); (wf); \ + intel_runtime_pm_put(i915, (wf)), (wf) = 0) -:513: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #513: FILE: drivers/gpu/drm/i915/intel_drv.h:2190: +#define with_intel_runtime_pm(i915, wf) \ + for ((wf) = intel_runtime_pm_get(i915); (wf); \ + intel_runtime_pm_put(i915, (wf)), (wf) = 0) -:517: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #517: FILE: drivers/gpu/drm/i915/intel_drv.h:2194: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(i915); (wf); \ + intel_runtime_pm_put(i915, (wf)), (wf) = 0) -:517: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #517: FILE: drivers/gpu/drm/i915/intel_drv.h:2194: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(i915); (wf); \ + intel_runtime_pm_put(i915, (wf)), (wf) = 0) total: 0 errors, 0 warnings, 4 checks, 734 lines checked adda353c332e drm/i915: Markup paired operations on display power domains 57f1d83af1b8 drm/i915: Track the wakeref used to initialise display power domains -:214: WARNING:LINE_SPACING: Missing a blank line after declarations #214: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:4149: + struct i915_power_domains *power_domains = &i915->power_domains; + intel_wakeref_t wakeref __maybe_unused = total: 0 errors, 1 warnings, 0 checks, 324 lines checked ffcfcfce0a8e drm/i915: Combined gt.awake/gt.power wakerefs dae8d188692d drm/i915/dp: Markup pps lock power well -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dp' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/intel_dp.c:634: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/intel_dp.c:634: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) total: 0 errors, 0 warnings, 2 checks, 430 lines checked 20a65c10474c drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice f0e17f7e1c9f drm/i915: Mark up Ironlake ips with rpm wakerefs _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx