On 04/01/2019 12:13, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-01-02 15:21:21)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 36177546f68b..7b80a087cc32 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -917,6 +917,9 @@ static bool ring_is_idle(struct intel_engine_cs *engine)
intel_wakeref_t wakeref;
bool idle = true;
+ if (I915_SELFTEST_ONLY(!engine->mmio_base))
+ return true;
Seems to make sense, but shouldn't the patch title be "Use
engine->mmio_base as predicate for mock engine hw access"?
But we use b->irq_enable for the important bit.
You mean in irq_enable/disable helpers? But that's the same before and
after the patch. The change seems to be dropping of selftests specific
variable in favour of engine->mmio_base. Am I blind again?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
