== Series Details == Series: drm/i915: from module params to device params URL : https://patchwork.freedesktop.org/series/54414/ State : warning == Summary == $ dim checkpatch origin/drm-tip 586195831aff drm/i915: add a helper to make a copy of i915_params -:53: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #53: FILE: drivers/gpu/drm/i915/i915_params.c:216: +#define DUP(T, x, ...) dup_param(#T, &dest->x); -:53: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #53: FILE: drivers/gpu/drm/i915/i915_params.c:216: +#define DUP(T, x, ...) dup_param(#T, &dest->x); total: 0 errors, 1 warnings, 1 checks, 43 lines checked 0812143284ad drm/i915: add a helper to free the members of i915_params -:54: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #54: FILE: drivers/gpu/drm/i915/i915_params.c:232: +#define FREE(T, x, ...) free_param(#T, ¶ms->x); -:54: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #54: FILE: drivers/gpu/drm/i915/i915_params.c:232: +#define FREE(T, x, ...) free_param(#T, ¶ms->x); total: 0 errors, 1 warnings, 1 checks, 44 lines checked 4509a9377d1c drm/i915/uc: add dev_priv parameter to intel_uc_is_using_* functions 6a59dbd9d959 drm/i915/params: set i915.enable_hangcheck permissions to 0600 -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #26: FILE: drivers/gpu/drm/i915/i915_params.c:81: +i915_param_named_unsafe(enable_hangcheck, bool, 0600, "Periodically check GPU activity for detecting hangs. " total: 0 errors, 0 warnings, 1 checks, 8 lines checked 305ba63bcf19 drm/i915: move load failure injection to selftests a2297526194c drm/i915/params: document I915_PARAMS_FOR_EACH() 53915b3c08cf drm/i915/params: add i915 parameters to debugfs -:88: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #88: FILE: drivers/gpu/drm/i915/i915_debugfs.c:101: +static ssize_t i915_param_uint_write(struct file *file, + const char __user *ubuf, size_t len, -:215: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #215: FILE: drivers/gpu/drm/i915/i915_debugfs.c:228: +#define REGISTER(T, x, unused, mode, ...) _i915_param_create_file(dir, #x, #T, mode, ¶ms->x); -:215: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #215: FILE: drivers/gpu/drm/i915/i915_debugfs.c:228: +#define REGISTER(T, x, unused, mode, ...) _i915_param_create_file(dir, #x, #T, mode, ¶ms->x); total: 0 errors, 1 warnings, 2 checks, 298 lines checked 80c374cedf12 drm/i915/debugfs: support bool values for int and uint params -:23: WARNING:LINE_SPACING: Missing a blank line after declarations #23: FILE: drivers/gpu/drm/i915/i915_debugfs.c:67: + bool b; + ret = kstrtobool_from_user(ubuf, len, &b); -:37: WARNING:LINE_SPACING: Missing a blank line after declarations #37: FILE: drivers/gpu/drm/i915/i915_debugfs.c:119: + bool b; + ret = kstrtobool_from_user(ubuf, len, &b); total: 0 errors, 2 warnings, 0 checks, 26 lines checked 29ef2d634ac8 drm/i915/params: prevent changing module params runtime -:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #52: FILE: drivers/gpu/drm/i915/i915_params.c:61: +i915_param_named_unsafe(enable_fbc, int, 0400, "Enable frame buffer compression for power savings " -:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #61: FILE: drivers/gpu/drm/i915/i915_params.c:69: +i915_param_named_unsafe(panel_use_ssc, int, 0400, "Use Spread Spectrum Clock with panels [LVDS/eDP] " -:70: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #70: FILE: drivers/gpu/drm/i915/i915_params.c:77: +i915_param_named_unsafe(reset, int, 0400, "Attempt GPU resets (0=disabled, 1=full gpu reset, 2=engine reset [default])"); -:78: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #78: FILE: drivers/gpu/drm/i915/i915_params.c:84: +i915_param_named(error_capture, bool, 0400, "Record the GPU state following a hang. " -:85: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #85: FILE: drivers/gpu/drm/i915/i915_params.c:90: +i915_param_named_unsafe(enable_hangcheck, bool, 0400, "Periodically check GPU activity for detecting hangs. " -:91: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #91: FILE: drivers/gpu/drm/i915/i915_params.c:95: +i915_param_named_unsafe(enable_psr, int, 0400, "Enable PSR " -:103: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #103: FILE: drivers/gpu/drm/i915/i915_params.c:110: +i915_param_named(fastboot, bool, 0400, "Try to skip unnecessary mode sets at boot time (default: false)"); -:107: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #107: FILE: drivers/gpu/drm/i915/i915_params.c:113: +i915_param_named_unsafe(prefault_disable, bool, 0400, "Disable page prefaulting for pread/pwrite/reloc (default:false). " -:112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #112: FILE: drivers/gpu/drm/i915/i915_params.c:117: +i915_param_named_unsafe(load_detect_test, bool, 0400, "Force-enable the VGA load detect code for testing (default:false). " -:117: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #117: FILE: drivers/gpu/drm/i915/i915_params.c:121: +i915_param_named_unsafe(force_reset_modeset_test, bool, 0400, "Force a modeset during gpu reset for testing (default:false). " -:122: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #122: FILE: drivers/gpu/drm/i915/i915_params.c:125: +i915_param_named_unsafe(invert_brightness, int, 0400, "Invert backlight brightness " -:131: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #131: FILE: drivers/gpu/drm/i915/i915_params.c:135: +i915_param_named(mmio_debug, int, 0400, "Enable the MMIO debug code for the first N failures (default: off). " -:144: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #144: FILE: drivers/gpu/drm/i915/i915_params.c:170: +i915_param_named_unsafe(enable_dp_mst, bool, 0400, "Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)"); -:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #148: FILE: drivers/gpu/drm/i915/i915_params.c:173: +i915_param_named(enable_dpcd_backlight, bool, 0400, "Enable support for DPCD backlight control (default:false)"); total: 0 errors, 0 warnings, 14 checks, 114 lines checked b7a1deaff9b1 drm/i915/params: switch to device specific parameters fd33cc4237ef drm/i915/params: hide i915_modparams within i915_params.c _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
