Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

["C, Ramalingam" <ramalingam.c@xxxxxxxxx>]

On 12/20/2018 9:36 PM, Winkler, Tomas wrote:

+static void __exit mei_hdcp_exit(void)

+{

+       mei_hdcp_component_cleanup(&cldev->dev);

Don’t think you can do that,  no guarantees this will be valid pointer

As we discussed offline, we have the below line at cleanup.
So valid pointer is made sure. I will protect init and cleanup with mutex too.

+static void mei_hdcp_component_cleanup(struct device *dev)
+{
+       if (!mei_hdcp_component_registered)
+               return;

-Ram

+       mei_cldev_driver_unregister(mei_hdcp_driver);

+}

+

+module_init(mei_hdcp_init);

+module_exit(mei_hdcp_exit);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx