Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> writes:
> Make csb entry count variable in preparation for larger
> CSB status FIFO size found on gen11+ hardware.
>
> v2: adapt to hwsp access only (Chris)
> non continuous mmio (Daniele)
> v3: entries (Chris), fix macro for checkpatch
> v4: num_entries (Chris)
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 23 ++++++++++++----------
> drivers/gpu/drm/i915/intel_lrc.c | 7 +++++--
> drivers/gpu/drm/i915/intel_lrc.h | 26 ++++++++++++++++++-------
> drivers/gpu/drm/i915/intel_ringbuffer.h | 5 +++++
> 4 files changed, 42 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index d3dec31df123..d759ebb44cdc 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1336,37 +1336,40 @@ static void intel_engine_print_registers(const struct intel_engine_cs *engine,
> }
>
> if (HAS_EXECLISTS(dev_priv)) {
> - const u32 *hws = &engine->status_page.page_addr[I915_HWS_CSB_BUF0_INDEX];
> + const u32 *hws = execlists->csb_status;
> + const u8 entries = execlists->csb_size;
Oh, I had a one job :O
-Mika
> unsigned int idx;
> u8 read, write;
>
> - drm_printf(m, "\tExeclist status: 0x%08x %08x\n",
> + drm_printf(m, "\tExeclist status: 0x%08x %08x, entries %u\n",
> I915_READ(RING_EXECLIST_STATUS_LO(engine)),
> - I915_READ(RING_EXECLIST_STATUS_HI(engine)));
> + I915_READ(RING_EXECLIST_STATUS_HI(engine)),
> + entries);
>
> read = execlists->csb_head;
> write = READ_ONCE(*execlists->csb_write);
>
> drm_printf(m, "\tExeclist CSB read %d, write %d [mmio:%d], tasklet queued? %s (%s)\n",
> read, write,
> - GEN8_CSB_WRITE_PTR(I915_READ(RING_CONTEXT_STATUS_PTR(engine))),
> + I915_READ(RING_CONTEXT_STATUS_PTR(engine)) &
> + GEN11_CSB_WRITE_PTR_MASK,
> yesno(test_bit(TASKLET_STATE_SCHED,
> &engine->execlists.tasklet.state)),
> enableddisabled(!atomic_read(&engine->execlists.tasklet.count)));
> - if (read >= GEN8_CSB_ENTRIES)
> + if (read >= entries)
> read = 0;
> - if (write >= GEN8_CSB_ENTRIES)
> + if (write >= entries)
> write = 0;
> if (read > write)
> - write += GEN8_CSB_ENTRIES;
> + write += entries;
> while (read < write) {
> - idx = ++read % GEN8_CSB_ENTRIES;
> + idx = ++read % entries;
> drm_printf(m, "\tExeclist CSB[%d]: 0x%08x [mmio:0x%08x], context: %d [mmio:%d]\n",
> idx,
> hws[idx * 2],
> - I915_READ(RING_CONTEXT_STATUS_BUF_LO(engine, idx)),
> + I915_READ(RING_CSB_LO(engine, idx)),
> hws[idx * 2 + 1],
> - I915_READ(RING_CONTEXT_STATUS_BUF_HI(engine, idx)));
> + I915_READ(RING_CSB_HI(engine, idx)));
> }
>
> rcu_read_lock();
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index b05d0561f99a..3594d489bd9f 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -760,7 +760,7 @@ invalidate_csb_entries(const u32 *first, const u32 *last)
>
> static void reset_csb_pointers(struct intel_engine_execlists *execlists)
> {
> - const unsigned int reset_value = GEN8_CSB_ENTRIES - 1;
> + const unsigned int reset_value = execlists->csb_size - 1;
>
> /*
> * After a reset, the HW starts writing into CSB entry [0]. We
> @@ -867,6 +867,7 @@ static void process_csb(struct intel_engine_cs *engine)
> struct intel_engine_execlists * const execlists = &engine->execlists;
> struct execlist_port *port = execlists->port;
> const u32 * const buf = execlists->csb_status;
> + const u8 num_entries = execlists->csb_size;
> u8 head, tail;
>
> /*
> @@ -900,7 +901,7 @@ static void process_csb(struct intel_engine_cs *engine)
> unsigned int status;
> unsigned int count;
>
> - if (++head == GEN8_CSB_ENTRIES)
> + if (++head == num_entries)
> head = 0;
>
> /*
> @@ -2252,6 +2253,8 @@ static int logical_ring_init(struct intel_engine_cs *engine)
> execlists->csb_write =
> &engine->status_page.page_addr[intel_hws_csb_write_index(i915)];
>
> + execlists->csb_size = GEN8_CSB_ENTRIES;
> +
> reset_csb_pointers(execlists);
>
> return 0;
> diff --git a/drivers/gpu/drm/i915/intel_lrc.h b/drivers/gpu/drm/i915/intel_lrc.h
> index f5a5502ecf70..c95f05f172d9 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.h
> +++ b/drivers/gpu/drm/i915/intel_lrc.h
> @@ -36,9 +36,20 @@
> #define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT (1 << 0)
> #define CTX_CTRL_RS_CTX_ENABLE (1 << 1)
> #define CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT (1 << 2)
> -#define RING_CONTEXT_STATUS_BUF_BASE(engine) _MMIO((engine)->mmio_base + 0x370)
> -#define RING_CONTEXT_STATUS_BUF_LO(engine, i) _MMIO((engine)->mmio_base + 0x370 + (i) * 8)
> -#define RING_CONTEXT_STATUS_BUF_HI(engine, i) _MMIO((engine)->mmio_base + 0x370 + (i) * 8 + 4)
> +
> +#define RING_CSB_0_5 0x370
> +#define RING_CSB_6_12 0x3c0
> +
> +#define _RING_CSB_OFFSET(entry) ({ \
> + const int i = (entry); \
> + i < 6 ? \
> + RING_CSB_0_5 + i * 8 : \
> + RING_CSB_6_12 + (i - 6) * 8; \
> +})
> +
> +#define RING_CSB_OFFSET(engine, i) ((engine)->mmio_base + _RING_CSB_OFFSET(i))
> +#define RING_CSB_LO(engine, i) _MMIO(RING_CSB_OFFSET(engine, i))
> +#define RING_CSB_HI(engine, i) _MMIO(RING_CSB_OFFSET(engine, i) + 4)
> #define RING_CONTEXT_STATUS_PTR(engine) _MMIO((engine)->mmio_base + 0x3a0)
> #define RING_EXECLIST_SQ_CONTENTS(engine) _MMIO((engine)->mmio_base + 0x510)
> #define RING_EXECLIST_CONTROL(engine) _MMIO((engine)->mmio_base + 0x550)
> @@ -55,10 +66,11 @@
> #define GEN8_CSB_PTR_MASK 0x7
> #define GEN8_CSB_READ_PTR_MASK (GEN8_CSB_PTR_MASK << 8)
> #define GEN8_CSB_WRITE_PTR_MASK (GEN8_CSB_PTR_MASK << 0)
> -#define GEN8_CSB_WRITE_PTR(csb_status) \
> - (((csb_status) & GEN8_CSB_WRITE_PTR_MASK) >> 0)
> -#define GEN8_CSB_READ_PTR(csb_status) \
> - (((csb_status) & GEN8_CSB_READ_PTR_MASK) >> 8)
> +
> +#define GEN11_CSB_ENTRIES 12
> +#define GEN11_CSB_PTR_MASK 0xf
> +#define GEN11_CSB_READ_PTR_MASK (GEN11_CSB_PTR_MASK << 8)
> +#define GEN11_CSB_WRITE_PTR_MASK (GEN11_CSB_PTR_MASK << 0)
>
> enum {
> INTEL_CONTEXT_SCHEDULE_IN = 0,
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index 6b41b9ce5f5b..c3dfd0f59912 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -332,6 +332,11 @@ struct intel_engine_execlists {
> */
> u32 preempt_complete_status;
>
> + /**
> + * @csb_size: context status buffer FIFO size
> + */
> + u8 csb_size;
> +
> /**
> * @csb_head: context status buffer head
> */
> --
> 2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
