On Fri, 20 Jul 2012 10:43:30 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: > Add the host bridge ID used by the simulator. This was added in a > previous patch for the agp layer, but wasn't preserved here. It also > gives us an opportunity to let the rest of the driver know we're running > as the simulator for various workarounds. I like how minimal this looks, though it does worry me that is a little too easy... (Not least the question why the simulator doesn't work with forcewake... Doesn't that strike you as odd that we have rc6 bugs and the simulator dies... ;-) I think I would rather see this as an intel_info so that it can be expanded upon simply for future/past simulators. However, the fundamental question is do we ever ship simulators? If we try to avoid carrying pre-production w/a, shouldn't that mean that we don't even contemplate pushing simulator interfaces. Having said, carrying these patches centrally does mean that will be reviewed and kept in mind for future iterations. -Chris -- Chris Wilson, Intel Open Source Technology Centre
