== Series Details == Series: Make GEN macros more similar (rev3) URL : https://patchwork.freedesktop.org/series/51860/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9a668a8393e8 drm/i915: Rename IS_GEN to IS_GEN_RANGE 80cf0c99318d drm/i915: replace IS_GEN<N> with IS_GEN(..., N) -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: gen_mask to do the comparison. Now callers can pass then gen as a parameter, -:265: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #265: FILE: drivers/gpu/drm/i915/i915_drv.h:2375: +#define IS_GEN9_LP(dev_priv) (IS_GEN(dev_priv, 9) && IS_LP(dev_priv)) -:266: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #266: FILE: drivers/gpu/drm/i915/i915_drv.h:2376: +#define IS_GEN9_BC(dev_priv) (IS_GEN(dev_priv, 9) && !IS_LP(dev_priv)) -:284: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #284: FILE: drivers/gpu/drm/i915/i915_drv.h:2449: +#define HAS_128_BYTE_Y_TILING(dev_priv) (!IS_GEN(dev_priv, 2) && \ !(IS_I915G(dev_priv) || \ IS_I915GM(dev_priv))) -:453: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!r" #453: FILE: drivers/gpu/drm/i915/i915_gem_stolen.c:159: + if (r == NULL && !IS_GEN(dev_priv, 3)) { -:1138: CHECK:CAMELCASE: Avoid CamelCase: <ILK_eDP_A_DISABLE> #1138: FILE: drivers/gpu/drm/i915/intel_display.c:14188: + if (IS_GEN(dev_priv, 5) && (I915_READ(FUSE_STRAP) & ILK_eDP_A_DISABLE)) total: 0 errors, 1 warnings, 5 checks, 1819 lines checked 89f3e86e75ec drm/i915: merge gen checks to use range _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
