On 05/12/2018 19:04, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Commit 71ffd49cc9b9 ("drm/i915/icl:Add Wa_1606682166") added the
workaround but did not put it in comment, which looks like should be the
usual process for these things. Add the missing comment.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
Cc: Anuj Phogat <anuj.phogat@xxxxxxxxx>
Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/i915/intel_workarounds.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
index 4f678c502daf..7c4c5e655d94 100644
--- a/drivers/gpu/drm/i915/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/intel_workarounds.c
@@ -1178,7 +1178,10 @@ static void rcs_engine_wa_init(struct intel_engine_cs *engine)
PMFLUSH_GAPL3UNBLOCK |
PMFLUSHDONE_LNEBLK);
- /* Wa_1406609255:icl (pre-prod) */
+ /*
+ * Wa_1406609255:icl (pre-prod): GEN7_DISABLE_DEMAND_PREFETCH
+ * Wa_1606682166:icl: GEN7_DISABLE_SAMPLER_PREFETCH
+ */
if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
wa_write_or(wal,
GEN7_SARCHKMD,
Actually who knows how to check if this second Wa/ applies to the same
steppings?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
