Quoting Chris Wilson (2018-11-30 21:08:08) > Quoting Tvrtko Ursulin (2018-11-30 17:44:10) > > u64 intel_engine_get_active_head(const struct intel_engine_cs *engine) > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > > index dfafc3f710d6..4eead104cd9c 100644 > > --- a/drivers/gpu/drm/i915/intel_lrc.c > > +++ b/drivers/gpu/drm/i915/intel_lrc.c > > @@ -2316,6 +2316,7 @@ int logical_render_ring_init(struct intel_engine_cs *engine) > > ret); > > } > > > > + intel_whitelist_workarounds_init(engine); > > intel_engine_workarounds_init(engine); > > So to play devil's advocate: > > intel_engine_init_whitelist(engine); > intel_engine_init_workarounds(engine); > > object_verb_subject > object = intel_engine > verb = init > subject / subcluase. > > I guess there's one more to see how it fits into the pattern... The guts are fine though, Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
