== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev11) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 094cd6f80a68 drm/i915: Reorganize plane register writes to make them more atomic ef3ad7085ebf drm/i915: Move single buffered plane register writes to the end 0384431cd12f drm/i915: Introduce crtc_state->update_planes bitmask 7107a3d9c003 drm/i915: Pass the new crtc_state to ->disable_plane() -:154: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #154: FILE: drivers/gpu/drm/i915/intel_display.h:401: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:154: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #154: FILE: drivers/gpu/drm/i915/intel_display.h:401: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:154: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #154: FILE: drivers/gpu/drm/i915/intel_display.h:401: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:158: WARNING:LONG_LINE: line over 100 characters #158: FILE: drivers/gpu/drm/i915/intel_display.h:405: + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ total: 0 errors, 1 warnings, 3 checks, 159 lines checked edbc517f0a76 drm/i915: Fix latency==0 handling for level 0 watermark on skl+ ef730820a9b9 drm/i915: Remove some useless zeroing on skl+ wm calculations c59c49fe42d5 drm/i915: Pass the entire skl_plane_wm to skl_compute_transition_wm() 900570f29731 drm/i915: Clean up skl+ vs. icl+ watermark computation 4611696fec9f drm/i915: Don't pass dev_priv around so much 378d0718daa0 drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+ -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #158: FILE: drivers/gpu/drm/i915/intel_display.h:434: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #158: FILE: drivers/gpu/drm/i915/intel_display.h:434: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #158: FILE: drivers/gpu/drm/i915/intel_display.h:434: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:162: WARNING:LONG_LINE: line over 100 characters #162: FILE: drivers/gpu/drm/i915/intel_display.h:438: + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ -:163: WARNING:LONG_LINE: line over 100 characters #163: FILE: drivers/gpu/drm/i915/intel_display.h:439: + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ total: 0 errors, 2 warnings, 3 checks, 836 lines checked 6581d1c88787 drm/i915: Commit skl+ planes in an order that avoids ddb overlaps 972e01e50301 drm/i915: Rename the confusing 'plane_id' to 'color_plane' f626b07e7e19 drm/i915: Pass the plane to icl_program_input_csc_coeff() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
