== Series Details == Series: Respin of remaining DSC + FEC patches URL : https://patchwork.freedesktop.org/series/52781/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72d53683f5ab drm/dsc: Modify DRM helper to return complete DSC color depth capabilities a82354d4ddcd drm/dsc: Define Display Stream Compression PPS infoframe -:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 342 lines checked 5c29875bf189 drm/dsc: Define VESA Display Stream Compression Capabilities -:34: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-developed-by: #34: Co-developed-by: Gaurav K Singh <gaurav.k.singh@xxxxxxxxx> -:73: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #73: FILE: include/drm/drm_dsc.h:40: + bool convert_rgb; -:83: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #83: FILE: include/drm/drm_dsc.h:50: + bool enable422; -:108: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #108: FILE: include/drm/drm_dsc.h:75: + bool block_pred_enable; -:136: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #136: FILE: include/drm/drm_dsc.h:103: + bool vbr_enable; -:151: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #151: FILE: include/drm/drm_dsc.h:118: + bool native_422; -:153: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #153: FILE: include/drm/drm_dsc.h:120: + bool native_420; total: 0 errors, 1 warnings, 6 checks, 121 lines checked fb2dad924fca drm/dsc: Define Rate Control values that do not change over configurations -:42: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 12 lines checked d1679441f001 drm/dsc: Add helpers for DSC picture parameter set infoframes -:79: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #79: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 285 lines checked de9e97e60143 drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants c24373fbec9f drm/i915/dp: Add DSC params and DSC config to intel_crtc_state -:49: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #49: FILE: drivers/gpu/drm/i915/intel_drv.h:942: + bool compression_enable; -:50: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #50: FILE: drivers/gpu/drm/i915/intel_drv.h:943: + bool dsc_split; total: 0 errors, 0 warnings, 2 checks, 22 lines checked db356f2721ef drm/i915/dp: Compute DSC pipe config in atomic check -:262: WARNING:TABSTOP: Statements should start on a tabstop #262: FILE: drivers/gpu/drm/i915/intel_dp.c:2025: + else total: 0 errors, 1 warnings, 0 checks, 262 lines checked be95861715ab drm/i915/dp: Do not enable PSR2 if DSC is enabled 9fbdaa92dab4 drm/i915/dsc: Define & Compute VESA DSC params -:68: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-developed-by: #68: Co-developed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> -:95: WARNING:MISSING_SPACE: break quoted strings at a space character #95: FILE: drivers/gpu/drm/i915/intel_dp.c:1957: + DRM_DEBUG_KMS("Cannot compute valid DSC parameters for Input Bpp = %d" + "Compressed BPP = %d\n", -:119: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #119: new file mode 100644 -:405: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #405: FILE: drivers/gpu/drm/i915/intel_vdsc.c:282: +} +}; total: 0 errors, 3 warnings, 1 checks, 496 lines checked db901e30a037 drm/i915/dsc: Compute Rate Control parameters for DSC -:141: CHECK:SPACING: space preferred before that '*' (ctx:VxE) #141: FILE: drivers/gpu/drm/i915/intel_vdsc.c:411: + vdsc_cfg->slice_bpg_offset)* ^ -:173: CHECK:LINE_SPACING: Please don't use multiple blank lines #173: FILE: drivers/gpu/drm/i915/intel_vdsc.c:443: + + total: 0 errors, 0 warnings, 2 checks, 136 lines checked 0b22b472ebcb drm/i915/dp: Enable/Disable DSC in DP Sink 45a2fece864d drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI f87a34c1eb7e drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling -:48: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #48: FILE: drivers/gpu/drm/i915/i915_drv.h:3344: +extern void intel_dsc_enable(struct intel_encoder *encoder, -:347: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #347: FILE: drivers/gpu/drm/i915/intel_vdsc.c:853: + rc_buf_thresh_dword[i/4] |= (u32)(vdsc_cfg->rc_buf_thresh[i] << ^ -:350: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #350: FILE: drivers/gpu/drm/i915/intel_vdsc.c:856: + rc_buf_thresh_dword[i/4]); ^ -:391: WARNING:LONG_LINE: line over 100 characters #391: FILE: drivers/gpu/drm/i915/intel_vdsc.c:897: + rc_range_params_dword[i/2] |= (u32)(((vdsc_cfg->rc_range_params[i].range_bpg_offset << -:391: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #391: FILE: drivers/gpu/drm/i915/intel_vdsc.c:897: + rc_range_params_dword[i/2] |= (u32)(((vdsc_cfg->rc_range_params[i].range_bpg_offset << ^ -:398: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #398: FILE: drivers/gpu/drm/i915/intel_vdsc.c:904: + rc_range_params_dword[i/2]); ^ -:476: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #476: FILE: drivers/gpu/drm/i915/intel_vdsc.c:982: +{ + -:483: WARNING:RETURN_VOID: void function return statements are not generally useful #483: FILE: drivers/gpu/drm/i915/intel_vdsc.c:989: + return; +} total: 0 errors, 2 warnings, 6 checks, 429 lines checked 4548baa9da14 drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs c34e300a58e5 drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes fb7745f881e6 drm/i915/dp: Configure Display stream splitter registers during DSC enable 417ab30c448b drm/i915/dp: Disable DSC in source by disabling DSS CTL bits -:35: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #35: FILE: drivers/gpu/drm/i915/i915_drv.h:3346: +extern void intel_dsc_disable(const struct intel_crtc_state *crtc_state); -:91: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #91: FILE: drivers/gpu/drm/i915/intel_vdsc.c:1063: + +} total: 0 errors, 0 warnings, 2 checks, 50 lines checked 82aebc9e1c88 drm/i915/dsc: Enable and disable appropriate power wells for VDSC fef051c49e3c i915/dp/fec: Add fec_enable to the crtc state. -:124: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #124: FILE: drivers/gpu/drm/i915/intel_drv.h:950: + bool fec_enable; total: 0 errors, 0 warnings, 1 checks, 64 lines checked d38e09c8d991 drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION ad56252fd46e i915/dp/fec: Configure the Forward Error Correction bits. e95ff6bc66aa drm/i915/fec: Disable FEC state. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
