== Series Details == Series: series starting with [v2,1/5] drm/i915: extract fixed point math to i915_fixed.h URL : https://patchwork.freedesktop.org/series/52608/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8b6b415c312d drm/i915: extract fixed point math to i915_fixed.h -:172: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #172: new file mode 100644 -:185: WARNING:NEW_TYPEDEFS: do not add new typedefs #185: FILE: drivers/gpu/drm/i915/i915_fixed.h:9: +typedef struct { -:243: WARNING:LINE_SPACING: Missing a blank line after declarations #243: FILE: drivers/gpu/drm/i915/i915_fixed.h:67: + uint_fixed_16_16_t fp; + WARN_ON(val > U32_MAX); -:244: CHECK:SPACING: No space is necessary after a cast #244: FILE: drivers/gpu/drm/i915/i915_fixed.h:68: + fp.val = (uint32_t) val; -:259: CHECK:SPACING: No space is necessary after a cast #259: FILE: drivers/gpu/drm/i915/i915_fixed.h:83: + intermediate_val = (uint64_t) val * mul.val; -:262: CHECK:SPACING: No space is necessary after a cast #262: FILE: drivers/gpu/drm/i915/i915_fixed.h:86: + return (uint32_t) intermediate_val; -:270: CHECK:SPACING: No space is necessary after a cast #270: FILE: drivers/gpu/drm/i915/i915_fixed.h:94: + intermediate_val = (uint64_t) val.val * mul.val; -:292: CHECK:SPACING: No space is necessary after a cast #292: FILE: drivers/gpu/drm/i915/i915_fixed.h:116: + return (uint32_t) interm_val; -:300: CHECK:SPACING: No space is necessary after a cast #300: FILE: drivers/gpu/drm/i915/i915_fixed.h:124: + intermediate_val = (uint64_t) val * mul.val; -:309: CHECK:SPACING: No space is necessary after a cast #309: FILE: drivers/gpu/drm/i915/i915_fixed.h:133: + interm_sum = (uint64_t) add1.val + add2.val; -:319: CHECK:SPACING: No space is necessary after a cast #319: FILE: drivers/gpu/drm/i915/i915_fixed.h:143: + interm_sum = (uint64_t) add1.val + interm_add2.val; total: 0 errors, 3 warnings, 8 checks, 298 lines checked 6f246d68ba40 drm/i915/fixed: prefer kernel types over stdint types a16ca22d5f12 drm/i915/fixed: simplify FP_16_16_MAX definition 6224a283b3bb drm/i915/fixed: simplify is_fixed16_zero() 50d2d523f15e drm/i915/fixed: cosmetic cleanup _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx