== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev7) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5a11dbcbd5cb drm/i915: Reorganize plane register writes to make them more atomic eb3c2f394649 drm/i915: Move single buffered plane register writes to the end 29f4a4966a76 drm/i915: Introduce crtc_state->update_planes bitmask eae12eaba5ea drm/i915: Pass the new crtc_state to ->disable_plane() -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:157: WARNING:LONG_LINE: line over 100 characters #157: FILE: drivers/gpu/drm/i915/intel_display.h:389: + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ total: 0 errors, 1 warnings, 3 checks, 159 lines checked b38354b977bd drm/i915: Fix latency==0 handling for level 0 watermark on skl+ 5217f4a8480a drm/i915: Remove some useless zeroing on skl+ wm calculations 81ef2cb52f82 drm/i915: Pass the entire skl_plane_wm to skl_compute_transition_wm() 35935ddd1f7b drm/i915: Clean up skl+ vs. icl+ watermark computation d52e2e45814c drm/i915: Don't pass dev_priv around so much b340dfdc7c50 drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+ -:161: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #161: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:161: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #161: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:161: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #161: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:165: WARNING:LONG_LINE: line over 100 characters #165: FILE: drivers/gpu/drm/i915/intel_display.h:422: + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ -:166: WARNING:LONG_LINE: line over 100 characters #166: FILE: drivers/gpu/drm/i915/intel_display.h:423: + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ total: 0 errors, 2 warnings, 3 checks, 744 lines checked 21fb8c0a9512 drm/i915: Commit skl+ planes in an order that avoids ddb overlaps cb22c9ec683c drm/i915: Rename the confusing 'plane_id' to 'color_plane' f21a10597270 drm/i915: Pass the plane to icl_program_input_csc_coeff() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
