== Series Details == Series: series starting with [01/13] locking/lockdep: restore cross-release checks (rev2) URL : https://patchwork.freedesktop.org/series/52167/ State : warning == Summary == $ dim checkpatch origin/drm-tip d34529c13d64 locking/lockdep: restore cross-release checks -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: commit dba04eb76df9 ("locking/Documentation: Remove stale crossrelease_fullstack parameter") -:69: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 -:645: WARNING:TYPO_SPELLING: 'prefered' may be misspelled - perhaps 'preferred'? #645: FILE: Documentation/locking/crossrelease.txt:572: +deadlock or its possibility sooner. So the former way would be prefered -:817: WARNING:TYPO_SPELLING: 'implmentation' may be misspelled - perhaps 'implementation'? #817: FILE: Documentation/locking/crossrelease.txt:744: +like how lockdep handles held_locks. Lockless implmentation is important -:840: WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'? #840: FILE: Documentation/locking/crossrelease.txt:767: +that it has not occured yet, lockdep should consider all possible -:987: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #987: FILE: include/linux/completion.h:53: +#define init_completion_map(x, m) \ +do { \ + lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \ + (m)->name, (m)->key, 0); \ + __init_completion(x); \ +} while (0) -:987: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects? #987: FILE: include/linux/completion.h:53: +#define init_completion_map(x, m) \ +do { \ + lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \ + (m)->name, (m)->key, 0); \ + __init_completion(x); \ +} while (0) -:994: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #994: FILE: include/linux/completion.h:60: +#define init_completion(x) \ +do { \ + static struct lock_class_key __key; \ + lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \ + "(completion)" #x, \ + &__key, 0); \ + __init_completion(x); \ +} while (0) -:1011: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'work' - possible side-effects? #1011: FILE: include/linux/completion.h:77: +#define COMPLETION_INITIALIZER(work) \ + { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \ + STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) } -:1109: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1109: FILE: include/linux/lockdep.h:305: + * Seperate stack_trace data. This will be used at commit step. -:1115: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1115: FILE: include/linux/lockdep.h:311: + * Seperate hlock instance. This will be used at commit step. -:1143: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1143: FILE: include/linux/lockdep.h:339: + * Seperate hlock instance. This will be used at commit step. -:1166: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1166: FILE: include/linux/lockdep.h:556: +extern void lockdep_init_map_crosslock(struct lockdep_map *lock, -:1170: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1170: FILE: include/linux/lockdep.h:560: +extern void lock_commit_crosslock(struct lockdep_map *lock); -:1190: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1190: FILE: include/linux/lockdep.h:580: +extern void crossrelease_hist_start(enum xhlock_context_t c); -:1191: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1191: FILE: include/linux/lockdep.h:581: +extern void crossrelease_hist_end(enum xhlock_context_t c); -:1192: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1192: FILE: include/linux/lockdep.h:582: +extern void lockdep_invariant_state(bool force); -:1193: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1193: FILE: include/linux/lockdep.h:583: +extern void lockdep_init_task(struct task_struct *task); -:1194: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1194: FILE: include/linux/lockdep.h:584: +extern void lockdep_free_task(struct task_struct *task); -:1309: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1309: FILE: kernel/locking/lockdep.c:1158: + printk(" Possible unsafe locking scenario by crosslock:\n\n"); -:1310: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1310: FILE: kernel/locking/lockdep.c:1159: + printk(" CPU0 CPU1\n"); -:1311: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1311: FILE: kernel/locking/lockdep.c:1160: + printk(" ---- ----\n"); -:1312: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1312: FILE: kernel/locking/lockdep.c:1161: + printk(" lock("); -:1314: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1314: FILE: kernel/locking/lockdep.c:1163: + printk(KERN_CONT ");\n"); -:1314: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1314: FILE: kernel/locking/lockdep.c:1163: + printk(KERN_CONT ");\n"); -:1315: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1315: FILE: kernel/locking/lockdep.c:1164: + printk(" lock("); -:1317: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1317: FILE: kernel/locking/lockdep.c:1166: + printk(KERN_CONT ");\n"); -:1317: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1317: FILE: kernel/locking/lockdep.c:1166: + printk(KERN_CONT ");\n"); -:1318: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1318: FILE: kernel/locking/lockdep.c:1167: + printk(" lock("); -:1320: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1320: FILE: kernel/locking/lockdep.c:1169: + printk(KERN_CONT ");\n"); -:1320: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1320: FILE: kernel/locking/lockdep.c:1169: + printk(KERN_CONT ");\n"); -:1321: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1321: FILE: kernel/locking/lockdep.c:1170: + printk(" unlock("); -:1323: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1323: FILE: kernel/locking/lockdep.c:1172: + printk(KERN_CONT ");\n"); -:1323: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1323: FILE: kernel/locking/lockdep.c:1172: + printk(KERN_CONT ");\n"); -:1324: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1324: FILE: kernel/locking/lockdep.c:1173: + printk("\n *** DEADLOCK ***\n\n"); -:1326: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1326: FILE: kernel/locking/lockdep.c:1175: + printk(" Possible unsafe locking scenario:\n\n"); -:1327: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1327: FILE: kernel/locking/lockdep.c:1176: + printk(" CPU0 CPU1\n"); -:1328: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1328: FILE: kernel/locking/lockdep.c:1177: + printk(" ---- ----\n"); -:1329: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1329: FILE: kernel/locking/lockdep.c:1178: + printk(" lock("); -:1331: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1331: FILE: kernel/locking/lockdep.c:1180: + printk(KERN_CONT ");\n"); -:1331: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1331: FILE: kernel/locking/lockdep.c:1180: + printk(KERN_CONT ");\n"); -:1332: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1332: FILE: kernel/locking/lockdep.c:1181: + printk(" lock("); -:1334: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1334: FILE: kernel/locking/lockdep.c:1183: + printk(KERN_CONT ");\n"); -:1334: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1334: FILE: kernel/locking/lockdep.c:1183: + printk(KERN_CONT ");\n"); -:1335: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1335: FILE: kernel/locking/lockdep.c:1184: + printk(" lock("); -:1337: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1337: FILE: kernel/locking/lockdep.c:1186: + printk(KERN_CONT ");\n"); -:1337: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1337: FILE: kernel/locking/lockdep.c:1186: + printk(KERN_CONT ");\n"); -:1338: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1338: FILE: kernel/locking/lockdep.c:1187: + printk(" lock("); -:1340: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1340: FILE: kernel/locking/lockdep.c:1189: + printk(KERN_CONT ");\n"); -:1340: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1340: FILE: kernel/locking/lockdep.c:1189: + printk(KERN_CONT ");\n"); -:1341: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1341: FILE: kernel/locking/lockdep.c:1190: + printk("\n *** DEADLOCK ***\n\n"); -:1477: CHECK:SPACING: spaces preferred around that '-' (ctx:WxV) #1477: FILE: kernel/locking/lockdep.c:2260: + chain_hlocks[chain->base + 1] = next -1; ^ -:1483: CHECK:BRACES: Unbalanced braces around else statement #1483: FILE: kernel/locking/lockdep.c:2266: + else { -:1514: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1514: FILE: kernel/locking/lockdep.c:3289: +void lockdep_init_map_crosslock(struct lockdep_map *lock, const char *name, + struct lock_class_key *key, int subclass) -:1899: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1899: FILE: kernel/locking/lockdep.c:4959: + if (nr_stack_trace_entries >= MAX_STACK_TRACE_ENTRIES-1) { ^ -:1926: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1926: FILE: kernel/locking/lockdep.c:4986: + if (!add_chain_cache_classes(xid, pid, xhlock->hlock.irq_context, + chain_key)) -:2061: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*task->xhlocks)...) over kzalloc(sizeof(struct hist_lock)...) #2061: FILE: kernel/locking/lockdep.c:5121: + task->xhlocks = kzalloc(sizeof(struct hist_lock) * MAX_XHLOCKS_NR, -:2069: WARNING:TYPO_SPELLING: 'Diable' may be misspelled - perhaps 'Disable'? #2069: FILE: kernel/locking/lockdep.c:5129: + /* Diable crossrelease for current */ -:2141: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 42 warnings, 17 checks, 2023 lines checked 0fd9815c65c9 kthread: finer-grained lockdep/cross-release completion -:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #49: FILE: include/linux/kthread.h:11: +struct task_struct *_kthread_create_on_node(int (*threadfn)(void *data), void *data, -:70: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #70: FILE: include/linux/kthread.h:39: +struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data), void *data, -:108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #108: FILE: include/linux/kthread.h:206: +_kthread_create_worker_on_cpu(int cpu, unsigned int flags, + struct lock_class_key *exited_key, -:139: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #139: FILE: kernel/kthread.c:234: + lockdep_init_map_crosslock(&self->exited.map.map, + "(kthread completion)->exited", -:139: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string #139: FILE: kernel/kthread.c:234: + "(kthread completion)->exited", -:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #143: FILE: kernel/kthread.c:238: + lockdep_init_map_crosslock(&self->parked.map.map, + "(kthread completion)->parked", -:143: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string #143: FILE: kernel/kthread.c:238: + "(kthread completion)->parked", -:209: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #209: FILE: kernel/kthread.c:454: +struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data), void *data, unsigned int cpu, -:297: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 3 warnings, 6 checks, 240 lines checked e7ff79710898 lockdep: Remove GFP_NOLOCKDEP annotation -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7e7844226f10 ("lockdep: allow to disable reclaim lockup detection")' #6: This was originally added in 7e7844226f10 ("lockdep: allow to disable -:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 32 lines checked aae2894bfc45 kernel/lockdep: Make cross-release a config option -:74: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 42 lines checked 06c79f0d65de mm: Check if mmu notifier callbacks are allowed to fail -:31: ERROR:SPACING: space required after that ',' (ctx:VxV) #31: FILE: mm/mmu_notifier.c:193: + WARN(blockable,"%pS callback failure not allowed\n", ^ -:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 8 lines checked 0223cf9d2a45 mm, notifier: Catch sleeping/blocking for !blockable -:44: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 90752f20c3a6 mm, notifier: Add a lockdep map for invalidate_range_start -:85: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 34 lines checked 4dce4ddd09e6 dma-fence: cross-release annotations -:40: CHECK:LINE_SPACING: Please don't use multiple blank lines #40: FILE: drivers/dma-buf/dma-fence.c:33: + -:100: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #100: FILE: include/linux/dma-fence.h:45: +} +static inline void dma_fence_wait_release(void) -:104: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #104: FILE: include/linux/dma-fence.h:49: +} +static inline void dma_fence_wait_release_commit(void) -:122: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 3 checks, 78 lines checked bc4bac3e3c4e reservation: Annotate dma_fence waits 4b864c2a1402 drm/i915: Annotate dma_fence waits -:14: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #14: creating a dma_fence_signal_opportunistic, which doesnt have the -:73: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 39 lines checked 2114fc3c606a drm/i915: annotate intel_atomic_commit_fence_wait -:66: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 6895428ac0f7 HAX FOR CI: Enable cross-release -:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 7 lines checked edc202dd3ab7 Revert "locking/lockdep, cpu/hotplug: Annotate AP thread" -:96: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 52 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
