On Tue, 06 Nov 2018 17:47:27 +0100, Tomasz Lis <tomasz.lis@xxxxxxxxx>
wrote:
[snip]
+static const struct drm_i915_mocs_entry icelake_mocs_table[] = {
+ GEN11_MOCS_ENTRIES
+ [16] = {
+ /* Reserved - For future use */
+ .control_value = MOCS_CONTROL_VALUE(LE_PAGETABLE, LE_TC_PAGETABLE,
+ 0, 0, 0, 0, 0, 0, 0, 0),
+ .l3cc_value = MOCS_L3CC_VALUE(0, 0, L3_DIRECT),
+ },
+ [17] = {
+ /* Reserved - For future use */
+ .control_value = MOCS_CONTROL_VALUE(LE_PAGETABLE, LE_TC_PAGETABLE,
+ 0, 0, 0, 0, 0, 0, 0, 0),
+ .l3cc_value = MOCS_L3CC_VALUE(0, 0, L3_DIRECT),
+ },
Hmm, these 2 entries are reserved (and all zeros) so maybe there so no need
to define them explicitly ? No one shall use them right now (same as
entries
24-61). If in the future these entries will be unreserved and correctly
defined
(table v2) then we can provide meaningful definitions back here.
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
