On Mon, Nov 05, 2018 at 12:25:52PM -0800, José Roberto de Souza wrote: > MST is only supported in DDI ports that have this hook, so the null > check can be dropped. > > Suggested-by: Imre Deak <imre.deak@xxxxxxxxx> > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> I feel that the extra check doesn't hurt since it is an "optional" hook, but I don't believe it would be possible to have any mst without this pre-enalble hook anyway so we can remove... Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > index d57dc7900eb1..34ac1a7c2202 100644 > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > @@ -209,8 +209,7 @@ static void intel_mst_pre_pll_enable_dp(struct intel_encoder *encoder, > struct intel_digital_port *intel_dig_port = intel_mst->primary; > struct intel_dp *intel_dp = &intel_dig_port->dp; > > - if (intel_dp->active_mst_links == 0 && > - intel_dig_port->base.pre_pll_enable) > + if (intel_dp->active_mst_links == 0) > intel_dig_port->base.pre_pll_enable(&intel_dig_port->base, > pipe_config, NULL); > } > -- > 2.19.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
