2012/7/3 Daniel Vetter <daniel.vetter at ffwll.ch>: > We already have this pattern at quite a few places, and moving part of > the modeset helper stuff into the driver will add more. > > v2: Don't clobber the crtc struct name with the macro parameter ... > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> Looks like you're missing some places: intel_lvds_mode_fixup() and intel_tv_mode_fixup(). http://paste.debian.net/177750/ (patch only compiled, not tested) (changes are trivial, so if pastebin expires it, you still know what to do) With that: Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com> -- Paulo Zanoni