>-----Original Message----- >From: Lucas De Marchi [mailto:lucas.de.marchi@xxxxxxxxx] >Sent: Wednesday, October 31, 2018 10:23 AM >To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx> >Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; De >Marchi, Lucas <lucas.demarchi@xxxxxxxxx> >Subject: Re: [PATCH] drm/i915/fia: FIA registers offset >implementation. > >On Wed, Oct 31, 2018 at 04:58:27PM +0000, Srivatsa, Anusha wrote: >> >>> > /* ICL PHY DFLEX registers */ >> >>> > -#define PORT_TX_DFLEXDPMLE1 _MMIO(0x1638C0) >> >>> > +#define PORT_TX_DFLEXDPMLE1 _MMIO(FIA1_BASE + >> >PORT_TX_DFLEXDPMLE1_OFFSET) >> > >> >IMO either: >> > >> >#define _PORT_TX_DFLEXDPMLE1 0x008C0 >> >#define PORT_TX_DFLEXDPMLE1 _MMIO(FIA1_BASE + >> >_PORT_TX_DFLEXDPMLE1) >> > >> >or just: >> > >> >#define PORT_TX_DFLEXDPMLE1 _MMIO(FIA1_BASE + 0x008C0) >> >> Makes sense. I ll make this change... > >I think the second option makes more sense. The additional underscored name >doesn't improve readability. Yes, so no special additional defines for offsets, just - #define PORT_TX_DFLEXDPMLE1 _MMIO(FIA1_BASE + 0x008C0) Anusha >Lucas De Marchi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
