On Wed, Oct 24, 2018 at 03:28:24PM -0700, Manasi Navare wrote:
> Basic DSC parameters and DSC configuration data needs to be computed
> for each of the requested mode during atomic check. This is
> required since for certain modes, valid DSC parameters and config
> data might not be computed in which case compression cannot be
> enabled for that mode.
> For that reason we need to add these params and config structure
> to the intel_crtc_state so that if valid this state information
> can directly be used while enabling DSC in atomic commit.
>
> v2:
> * Rebase on drm-tip (Manasi)
>
> Cc: Gaurav K Singh <gaurav.k.singh@xxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> Signed-off-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
> Reviewed-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_drv.h | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 2d7761b8ac07..45fd7894722b 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -53,6 +53,7 @@
> #include <drm/drm_auth.h>
> #include <drm/drm_cache.h>
> #include <drm/drm_util.h>
> +#include <drm/drm_dsc.h>
>
> #include "i915_params.h"
> #include "i915_reg.h"
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 62c051098859..27d47950f438 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -931,6 +931,15 @@ struct intel_crtc_state {
>
> /* Output down scaling is done in LSPCON device */
> bool lspcon_downsampling;
> +
> + /* Display Stream compression state */
> + struct {
> + bool compression_enable;
> + bool dsc_split;
> + u16 compressed_bpp;
> + u8 slice_count;
> + } dsc_params;
> + struct drm_dsc_config dp_dsc_cfg;
Ville, Jani should this be defined as a pointer to struct drm_dsc_config?
struct drm_dsc_config *dp_dsc_cfg
since we populate this in intel_dp_compute_config and then on only read during
commit.
Manasi
> };
>
> struct intel_crtc {
> --
> 2.18.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
