== Series Details == Series: series starting with [RFC,1/4] drm/i915: Add Display Gen info. URL : https://patchwork.freedesktop.org/series/51717/ State : warning == Summary == $ dim checkpatch origin/drm-tip 082cfae8228c drm/i915: Add Display Gen info. -:83: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #83: FILE: drivers/gpu/drm/i915/i915_pci.c:33: +#define GEN(x) .gen = (x), .gen_mask = BIT((x) - 1), \ + .display_gen = (x), .display_gen_mask = BIT((x)) -:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #86: FILE: drivers/gpu/drm/i915/i915_pci.c:36: +#define DISPLAY_GEN(x) .display_gen = (x), .display_gen_mask = BIT((x)) total: 0 errors, 0 warnings, 2 checks, 67 lines checked cbcd72519654 drm/i915: Finally recognize Geminilake as Gen10 Display -:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #24: FILE: drivers/gpu/drm/i915/i915_drv.h:2627: +#define HAS_GMBUS_BURST_READ(dev_priv) (INTEL_DISPLAY_GEN(dev_priv) >= 10 || \ IS_KABYLAKE(dev_priv)) total: 0 errors, 0 warnings, 1 checks, 252 lines checked 610ba30a4557 drm/i915: Use Display gen9 for gen9_bc || bxt a52eae0799cd drm/i915: Expand DISPLAY_GEN macro usage to display related files. -:604: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #604: FILE: drivers/gpu/drm/i915/intel_display.c:6636: + if ((INTEL_DISPLAY_GEN(dev_priv) > 4 || IS_G4X(dev_priv)) && adjusted_mode->crtc_hsync_start == adjusted_mode->crtc_hdisplay) -:765: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port == PORT_E' #765: FILE: drivers/gpu/drm/i915/intel_display.c:9494: + if (INTEL_DISPLAY_GEN(dev_priv) < 9 && (port == PORT_E) && I915_READ(LPT_TRANSCONF) & TRANS_ENABLE) { -:1094: CHECK:CAMELCASE: Avoid CamelCase: <ILK_eDP_A_DISABLE> #1094: FILE: drivers/gpu/drm/i915/intel_display.c:14036: + if (IS_DISPLAY_GEN5(dev_priv) && (I915_READ(FUSE_STRAP) & ILK_eDP_A_DISABLE)) -:1271: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1271: FILE: drivers/gpu/drm/i915/intel_display.c:15836: + unsigned reg = INTEL_DISPLAY_GEN(dev_priv) >= 6 ? SNB_GMCH_CTRL : INTEL_GMCH_CTRL; -:1946: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED' #1946: FILE: drivers/gpu/drm/i915/intel_psr.c:245: + if (INTEL_DISPLAY_GEN(dev_priv) >= 9 && (intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED)) { -:2052: WARNING:BRACES: braces {} are not necessary for single statement blocks #2052: FILE: drivers/gpu/drm/i915/intel_sdvo.c:2454: + if (INTEL_DISPLAY_GEN(dev_priv) >= 4 && IS_MOBILE(dev_priv)) { intel_attach_broadcast_rgb_property(&connector->base.base); } total: 0 errors, 2 warnings, 4 checks, 1856 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
