On Wed, Oct 17, 2018 at 03:09:54PM -0700, Manasi Navare wrote:
> On Wed, Oct 17, 2018 at 02:56:52PM -0700, Rodrigo Vivi wrote:
> > Since when it was introduced we forgot to add
> > this case so ICL was using a wrong signal_levels
> > as reference.
> >
> > Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing programming sequence for Combo PHY DDI")
> > Cc: José Roberto de Souza <jose.souza@xxxxxxxxx>
> > Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>
> yep this was missed indeed. The bxt_signal_levels() has a case for IS_ICELAKE() but
> that was never getting called. Thanks for fixing this.
>
> Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
pushed to dinq, thanks
>
> Manasi
>
> > ---
> > drivers/gpu/drm/i915/intel_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 1f098e509143..3384a9bbdafd 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -3790,7 +3790,7 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp)
> > uint32_t signal_levels, mask = 0;
> > uint8_t train_set = intel_dp->train_set[0];
> >
> > - if (IS_GEN9_LP(dev_priv) || IS_CANNONLAKE(dev_priv)) {
> > + if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 10) {
> > signal_levels = bxt_signal_levels(intel_dp);
> > } else if (HAS_DDI(dev_priv)) {
> > signal_levels = ddi_signal_levels(intel_dp);
> > --
> > 2.19.1
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
