Re: [PATCH 3/3] drm/i915/icl: Disable master intr before reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> writes:

> On 15/10/18 07:14, Mika Kuoppala wrote:
>> Disable master interrupt before reading level indications.
>> This will close a race where we get a level indication between
>> reading and disabling, generating an extra interrupt where we
>> could have avoided one.
>> 
>> Further, as the reading acts also as a post, replace the
>> write/post on the irq reset with the helper. On enabling side,
>> posting doesn't serve any purpose so it can also be replaced
>> with helper.
>> 
>> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
>> Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> ---
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>

All 3 patches pushed. Thank you all for review.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux