Re: [igt-dev] [PATCH i-g-t] tests/gem_set_tiling_vs_pwrite: Skip on unknown swizzling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/10/2018 13:34, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"), to be able to compare the bo against the test
pattern we need to skip the test if the swizzling is not compatible.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102575
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
---
Eeek confidence level low - is this correct?

Actually this is a slightly more subtle problem,
https://patchwork.freedesktop.org/patch/240327/

So assuming your patch is in, this IGT cannot actually work if any swizzling is in effect? Or without your patch, it should skip based on known_swizzling? Or is even that not enough?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux