== Series Details == Series: drm/i915: Clean up the wm mem latency stuff URL : https://patchwork.freedesktop.org/series/50802/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3acd8b6f70a5 drm/i915: Store all wm memory latency values in .1 usec units 77e42913e7cf drm/i915: Use the spr/cur latencies on vlv/chv/g4x 720e1b59c0b9 drm/i915: Eliminate skl_latency[] 835ecb45c0fd drm/i915: Add dev_priv->wm.num_levels and use it everywhere 56e36d0fdf5f drm/i915: Add DEFINE_SNPRINTF_ARRAY() -:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'values' may be better as '(values)' to avoid precedence issues #23: FILE: drivers/gpu/drm/i915/i915_utils.h:164: +#define DEFINE_SNPRINTF_ARRAY(name, type, values, index, fmt, ...) \ +void name(char *_str, size_t _len, const type *values, int _nelems) \ +{ \ + int index; \ + if (_len) \ + _str[0] = '\0'; \ + for (index = 0; index < _nelems; index++) { \ + int _r = snprintf(_str, _len, "%s" fmt, \ + index ? ", " : "", __VA_ARGS__); \ + if (_r >= _len) \ + return; \ + _str += _r; \ + _len -= _r; \ + } \ +} -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/i915_utils.h:164: +#define DEFINE_SNPRINTF_ARRAY(name, type, values, index, fmt, ...) \ +void name(char *_str, size_t _len, const type *values, int _nelems) \ +{ \ + int index; \ + if (_len) \ + _str[0] = '\0'; \ + for (index = 0; index < _nelems; index++) { \ + int _r = snprintf(_str, _len, "%s" fmt, \ + index ? ", " : "", __VA_ARGS__); \ + if (_r >= _len) \ + return; \ + _str += _r; \ + _len -= _r; \ + } \ +} -:23: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #23: FILE: drivers/gpu/drm/i915/i915_utils.h:164: +#define DEFINE_SNPRINTF_ARRAY(name, type, values, index, fmt, ...) \ +void name(char *_str, size_t _len, const type *values, int _nelems) \ +{ \ + int index; \ + if (_len) \ + _str[0] = '\0'; \ + for (index = 0; index < _nelems; index++) { \ + int _r = snprintf(_str, _len, "%s" fmt, \ + index ? ", " : "", __VA_ARGS__); \ + if (_r >= _len) \ + return; \ + _str += _r; \ + _len -= _r; \ + } \ +} -:24: CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #24: FILE: drivers/gpu/drm/i915/i915_utils.h:165: +void name(char *_str, size_t _len, const type *values, int _nelems) \ ^ total: 0 errors, 1 warnings, 3 checks, 43 lines checked f3ddc18d8e10 drm/i915: Make the WM memory latency print more compact 3e81eb4b15b0 drm/i915: Eliminate redundant ilk sprite/cursor wm fixup code aaa6aab9e9f2 drm/i915: Split skl+ and ilk+ read_wm_latency() 2e6e43af1f55 drm/i915: Sanitize wm latency values for ilk+ 4d7823f8cfea drm/i915: Drop the funky ilk wm setup cc9ff8c60c9f drm/i915: Allow LP3 watermarks on ILK 9ca6798844ad drm/i915: Remove the remnants of the ilk+ LP0 wm hack _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
