On Wed, 10 Oct 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > When reporting the DPCD dump through debugfs, show the errors inline > where appropriate. If a read at one particular offset fails, report it > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106371 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> This'll be phased out anyway in favor of using the DP aux device node. > --- > drivers/gpu/drm/i915/i915_debugfs.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 4565eda29c87..00c551d3e409 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -4915,13 +4915,10 @@ static int i915_dpcd_show(struct seq_file *m, void *data) > continue; > > err = drm_dp_dpcd_read(&intel_dp->aux, b->offset, buf, size); > - if (err <= 0) { > - DRM_ERROR("dpcd read (%zu bytes at %u) failed (%zd)\n", > - size, b->offset, err); > - continue; > - } > - > - seq_printf(m, "%04x: %*ph\n", b->offset, (int) size, buf); > + if (err < 0) > + seq_printf(m, "%04x: ERROR %d\n", b->offset, (int)err); > + else > + seq_printf(m, "%04x: %*ph\n", b->offset, (int)err, buf); > } > > return 0; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
