On Tue, Oct 09, 2018 at 05:32:49PM +0300, Jani Nikula wrote: > On Tue, 09 Oct 2018, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote: > >> VESA eDP 1.4 specification has separate fields defined in > >> EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions. > >> This patch defines those. Found this when one of my eDP panels > >> advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field. > >> > >> Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > >> Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> > >> Signed-off-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> > >> --- > >> include/drm/drm_dp_helper.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > >> index 2a3843f248cf..9ad98e8d9ede 100644 > >> --- a/include/drm/drm_dp_helper.h > >> +++ b/include/drm/drm_dp_helper.h > >> @@ -685,6 +685,8 @@ > >> # define DP_EDP_12 0x01 > >> # define DP_EDP_13 0x02 > >> # define DP_EDP_14 0x03 > >> +# define DP_EDP_14a 0x04 /* eDP 1.4a */ > >> +# define DP_EDP_14b 0x05 /* eDP 1.4b */ > > > > The comments seem a bit redundant. > > > > Either way > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > So I guess we'll need code changing our == checks to >= checks. > We already have >= check in edp_init_dpcd and then in compute_config, we check for < DP_EDP_14 to set to max link rate /lane count. So checks wise we shuld be good for now. Manasi > BR, > Jani. > > > > >> > >> #define DP_EDP_GENERAL_CAP_1 0x701 > >> # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0) > >> -- > >> 2.18.0 > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
