On Thu, Oct 04, 2018 at 04:23:45PM -0700, Paulo Zanoni wrote: > Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu: > > From: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> > > > > Add missing MODULE_FIRMWARE while loading DMC ICL. > > > > v2: Add Fixes tag. (Rodrigo) > > v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr: > > restructure CSR firmware definition macros") > > v4: Rodrigo fixing his own mess on commit mentioning on v3 > > comment above. > > > > Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.") > > Yes, please. I wasted time because I lacked this commit. > > Tested-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> pushed, thanks > > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> (v2) > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_csr.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_csr.c > > b/drivers/gpu/drm/i915/intel_csr.c > > index e4e310b0ef78..fc7bd21fa586 100644 > > --- a/drivers/gpu/drm/i915/intel_csr.c > > +++ b/drivers/gpu/drm/i915/intel_csr.c > > @@ -37,6 +37,7 @@ > > #define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bi > > n" > > #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7) > > #define ICL_CSR_MAX_FW_SIZE 0x6000 > > +MODULE_FIRMWARE(ICL_CSR_PATH); > > > > #define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bi > > n" > > #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7) > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx