Quoting Mika Kuoppala (2018-10-02 15:05:49) > Disable master interrupt before reading level indications. > This will close a race where we get a level indication between > reading and disabling, generating an extra interrupt where we > could have avoided one. > > Further, as the reading acts also as a post, replace the > write/post on the irq reset with the helper. On enabling side, > posting doesn't serve any purpose so it can also be replaced > with helper. > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> Proof is in the eating and your experiments have shown that MASTER_IRQ is not cleared until the sublevels are acked. If it were the opposite then we would quickly see missed interrupts. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Though I would run it through CI a few times before merging just in case. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
