Re: [RFC 1/4] drm/i915/registers: prefer GENMASK() over hand rolled masks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC 1/4] drm/i915/registers: prefer GENMASK() over hand rolled masks
From: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
Date: Fri, 28 Sep 2018 11:34:42 +0300
Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
In-reply-to: <06ebf23f1d83d11ab4863b47b0c3041b6639c3fb.1538040594.git.jani.nikula@intel.com>
References: <cover.1538040594.git.jani.nikula@intel.com> <06ebf23f1d83d11ab4863b47b0c3041b6639c3fb.1538040594.git.jani.nikula@intel.com>

Jani Nikula <jani.nikula@xxxxxxxxx> writes:

> GENMASK() is much easier to get right and review against the specs than
> hand rolled masks.
>
+1

-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

References:
- [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros
  - From: Jani Nikula
- [RFC 1/4] drm/i915/registers: prefer GENMASK() over hand rolled masks
  - From: Jani Nikula

Prev by Date: Re: [RFC 02/10] drm/i915/gvt: get ready of memory for pvmmio
Next by Date: [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use
Previous by thread: [RFC 1/4] drm/i915/registers: prefer GENMASK() over hand rolled masks
Next by thread: [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()
Index(es):
- Date
- Thread

[Index of Archives] [AMD Graphics] [Linux USB Devel] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux