Re: [PATCH] drm/i915: Log HWS seqno consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2018-09-26 12:12:17)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> We mix hexa- and decimal which is confusing when reading the logs. So make
> the single odd one out instance decimal for consistency.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
> Later we can consider whether we should move them all to unsigned, or hex,
> etc..
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4b28225320ff..ad93aa4b0a6e 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
>         unsigned long flags;
>         u32 *regs;
>  
> -       GEM_TRACE("%s request global=%x, current=%d\n",
> +       GEM_TRACE("%s request global=%d, current=%d\n",
>                   engine->name, request ? request->global_seqno : 0,
>                   intel_engine_get_seqno(engine));
>  

One more in intel_ringbuffer.c
drivers/gpu/drm/i915/intel_ringbuffer.c:        GEM_TRACE("%s seqno=%x\n", engine->name, rq ? rq->global_seqno : 0);
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux