Em Ter, 2018-09-25 às 15:05 +0300, Ville Syrjälä escreveu: > On Mon, Sep 24, 2018 at 05:19:12PM -0700, Paulo Zanoni wrote: > > Because we can, the places where we use them already expect const > > structs. > > https://patchwork.freedesktop.org/series/44104/ already has the rest > of > the series covered. It didn't get pushed due to lack of drm-misc > backmerge. I suppose that's no longer an issue, but now the series > most likely needs a rebase. Please try to move forward with what's already reviewed so we can prevent a third person from reimplementing these improvements :). > > > > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index fdff1779f778..a21ec8ae46f6 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -13467,7 +13467,7 @@ static bool > > intel_cursor_format_mod_supported(struct drm_plane *_plane, > > format == DRM_FORMAT_ARGB8888; > > } > > > > -static struct drm_plane_funcs skl_plane_funcs = { > > +static const struct drm_plane_funcs skl_plane_funcs = { > > .update_plane = drm_atomic_helper_update_plane, > > .disable_plane = drm_atomic_helper_disable_plane, > > .destroy = intel_plane_destroy, > > @@ -13478,7 +13478,7 @@ static struct drm_plane_funcs > > skl_plane_funcs = { > > .format_mod_supported = skl_plane_format_mod_supported, > > }; > > > > -static struct drm_plane_funcs i965_plane_funcs = { > > +static const struct drm_plane_funcs i965_plane_funcs = { > > .update_plane = drm_atomic_helper_update_plane, > > .disable_plane = drm_atomic_helper_disable_plane, > > .destroy = intel_plane_destroy, > > @@ -13489,7 +13489,7 @@ static struct drm_plane_funcs > > i965_plane_funcs = { > > .format_mod_supported = i965_plane_format_mod_supported, > > }; > > > > -static struct drm_plane_funcs i8xx_plane_funcs = { > > +static const struct drm_plane_funcs i8xx_plane_funcs = { > > .update_plane = drm_atomic_helper_update_plane, > > .disable_plane = drm_atomic_helper_disable_plane, > > .destroy = intel_plane_destroy, > > -- > > 2.14.4 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx