Re: [PATCH 3/4] drm/i915: set optimum eu/slice/sub-slice configuration based on load type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Praveen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc4 next-20180921]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/kedar-j-karanje-intel-com/drm-i915-Get-active-pending-request-for-given-context/20180923-012250
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x014-201838 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_gem_context.c: In function 'i915_set_optimum_config':
>> drivers/gpu/drm/i915/i915_gem_context.c:434:6: error: unused variable 'rpcs_config' [-Werror=unused-variable]
     u32 rpcs_config = 0;
         ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem_context.c:433:7: error: unused variable 'reg_state' [-Werror=unused-variable]
     u32 *reg_state = ce->lrc_reg_state;
          ^~~~~~~~~
   cc1: all warnings being treated as errors

vim +/rpcs_config +434 drivers/gpu/drm/i915/i915_gem_context.c

   427	
   428	
   429	void i915_set_optimum_config(int type, struct i915_gem_context *ctx,
   430			enum gem_tier_versions version)
   431	{
   432		struct intel_context *ce = &ctx->__engine[RCS];
 > 433		u32 *reg_state = ce->lrc_reg_state;
 > 434		u32 rpcs_config = 0;
   435		/* Call opt_config to get correct configuration for eu,slice,subslice */
   436		ctx->slice_cnt = (u8)opt_config[version][type].slice;
   437		ctx->subslice_cnt = (u8)opt_config[version][type].subslice;
   438		ctx->eu_cnt = (u8)opt_config[version][type].eu;
   439	
   440		/* Enabling this to update the rpcs */
   441		if (ctx->prev_load_type != type)
   442			ctx->update_render_config = 1;
   443	
   444		ctx->prev_load_type = type;
   445	}
   446	/**
   447	 * i915_gem_context_create_gvt - create a GVT GEM context
   448	 * @dev: drm device *
   449	 *
   450	 * This function is used to create a GVT specific GEM context.
   451	 *
   452	 * Returns:
   453	 * pointer to i915_gem_context on success, error pointer if failed
   454	 *
   455	 */
   456	struct i915_gem_context *
   457	i915_gem_context_create_gvt(struct drm_device *dev)
   458	{
   459		struct i915_gem_context *ctx;
   460		int ret;
   461	
   462		if (!IS_ENABLED(CONFIG_DRM_I915_GVT))
   463			return ERR_PTR(-ENODEV);
   464	
   465		ret = i915_mutex_lock_interruptible(dev);
   466		if (ret)
   467			return ERR_PTR(ret);
   468	
   469		ctx = __create_hw_context(to_i915(dev), NULL);
   470		if (IS_ERR(ctx))
   471			goto out;
   472	
   473		ctx->file_priv = ERR_PTR(-EBADF);
   474		i915_gem_context_set_closed(ctx); /* not user accessible */
   475		i915_gem_context_clear_bannable(ctx);
   476		i915_gem_context_set_force_single_submission(ctx);
   477		if (!USES_GUC_SUBMISSION(to_i915(dev)))
   478			ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
   479	
   480		GEM_BUG_ON(i915_gem_context_is_kernel(ctx));
   481	out:
   482		mutex_unlock(&dev->struct_mutex);
   483		return ctx;
   484	}
   485	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux