Re: [PATCH 11/40] drm/i915/execlists: Onion unwind for logical_ring_init() failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 20/09/2018 20:59, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-09-20 15:21:47)

On 19/09/2018 20:55, Chris Wilson wrote:
Fix up the error unwind for logical_ring_init() failing by moving the

Could you say in the commit what was broken?

We didn't cleanup all the state we allocated in the caller.

That was kind of obvious, but it would have been helpful to the reviewer at least, if not to the commit message quality itself, to say what exactly.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux