== Series Details == Series: series starting with [01/40] drm: Use default dma_fence hooks where possible for null syncobj URL : https://patchwork.freedesktop.org/series/49923/ State : warning == Summary == $ dim checkpatch origin/drm-tip db53c1c9bc91 drm: Use default dma_fence hooks where possible for null syncobj 77e2baa66cf6 drm: Fix syncobj handing of schedule() returning 0 0466e1b99db2 drm/i915/selftests: Live tests emit requests and so require rpm 849b9a5e54f4 drm/i915: Park the GPU on module load 22997135d8ef drm/i915: Handle incomplete Z_FINISH for compressed error states 4eb03b08ed0a drm/i915: Clear the error PTE just once on finish 0125ac1db1a3 drm/i915: Cache the error string dda3a9df7889 drm/i915/execlists: Avoid kicking priority on the current context 8bec72d91b02 drm/i915/selftests: Free the batch along the contexts error path 0af582c21e60 drm/i915/selftests: Basic stress test for rapid context switching f883600aab97 drm/i915/execlists: Onion unwind for logical_ring_init() failure 54a30e5f6ba6 drm/i915/execlists: Assert the queue is non-empty on unsubmitting -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: <0>[ 531.960431] drv_self-4806 7.... 527402570us : intel_gpu_reset: engine_mask=1, ret=0, retry=0 total: 0 errors, 1 warnings, 0 checks, 7 lines checked d949a956393f drm/i915: Reserve some priority bits for internal use d4dade02ac2f drm/i915: Combine multiple internal plists into the same i915_priolist bucket -:163: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #163: FILE: drivers/gpu/drm/i915/intel_lrc.c:367: + struct list_head *uninitialized_var(pl); -:281: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #281: FILE: drivers/gpu/drm/i915/intel_lrc.c:1180: + struct list_head *uninitialized_var(pl); -:310: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #310: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:310: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #310: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #314: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) -:314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #314: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) total: 0 errors, 2 warnings, 4 checks, 272 lines checked ab69b94ad492 drm/i915: Priority boost for new clients 9eb955168501 drm/i915: Pull scheduling under standalone lock -:145: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #145: new file mode 100644 -:150: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #150: FILE: drivers/gpu/drm/i915/i915_scheduler.c:1: +/* -:393: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #393: FILE: drivers/gpu/drm/i915/i915_scheduler.c:244: + struct list_head *uninitialized_var(pl); total: 0 errors, 3 warnings, 0 checks, 870 lines checked 1fc76a0359e0 drm/i915: Priority boost for waiting clients 8be0aefc32e3 drm/i915: Report the number of closed vma held by each context in debugfs -:43: WARNING:LONG_LINE: line over 100 characters #43: FILE: drivers/gpu/drm/i915/i915_debugfs.c:350: + seq_printf(m, "%s: %lu objects, %llu bytes (%llu active, %llu inactive, %llu global, %llu shared, %llu unbound, %llu closed)\n", \ total: 0 errors, 1 warnings, 0 checks, 169 lines checked 05be2e2d6f16 drm/i915: Remove debugfs/i915_ppgtt_info 5985e77c4002 drm/i915: Track all held rpm wakerefs -:105: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #105: FILE: drivers/gpu/drm/i915/i915_drv.h:1294: + spinlock_t debug_lock; total: 0 errors, 0 warnings, 1 checks, 571 lines checked 87bdf5a67717 drm/i915: Markup paired operations on wakerefs -:707: WARNING:NEW_TYPEDEFS: do not add new typedefs #707: FILE: drivers/gpu/drm/i915/i915_drv.h:131: +typedef depot_stack_handle_t intel_wakeref_t; total: 0 errors, 1 warnings, 0 checks, 2291 lines checked 78bfd7e76b95 drm/i915: Syntatic sugar for using intel_runtime_pm -:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #491: FILE: drivers/gpu/drm/i915/intel_drv.h:2066: +#define with_intel_runtime_pm(i915, wf) \ + for (wf = intel_runtime_pm_get(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #491: FILE: drivers/gpu/drm/i915/intel_drv.h:2066: +#define with_intel_runtime_pm(i915, wf) \ + for (wf = intel_runtime_pm_get(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #495: FILE: drivers/gpu/drm/i915/intel_drv.h:2070: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #495: FILE: drivers/gpu/drm/i915/intel_drv.h:2070: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) total: 0 errors, 0 warnings, 4 checks, 694 lines checked 01c1f8ef9e05 drm/i915: Markup paired operations on display power domains 5df99971b669 drm/i915: Track the wakeref used to initialise display power domains -:207: WARNING:LINE_SPACING: Missing a blank line after declarations #207: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:4116: + struct i915_power_domains *power_domains = &i915->power_domains; + intel_wakeref_t wakeref __maybe_unused = total: 0 errors, 1 warnings, 0 checks, 320 lines checked 0d6a6f256a4c drm/i915/dp: Markup pps lock power well -:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dp' - possible side-effects? #52: FILE: drivers/gpu/drm/i915/intel_dp.c:682: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) -:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #52: FILE: drivers/gpu/drm/i915/intel_dp.c:682: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) total: 0 errors, 0 warnings, 2 checks, 425 lines checked a373ff7a3fec drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice 0f9a343f4e3e drm/i915: Mark up Ironlake ips with rpm wakerefs -:210: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #210: FILE: drivers/gpu/drm/i915/intel_pm.c:7983: + chipset_val = graphics_val = 0; total: 0 errors, 0 warnings, 1 checks, 318 lines checked df26a76763aa drm/i915: Serialise concurrent calls to i915_gem_set_wedged() -:48: WARNING:MEMORY_BARRIER: memory barrier without comment #48: FILE: drivers/gpu/drm/i915/i915_gem.c:3404: + smp_mb__before_atomic(); total: 0 errors, 1 warnings, 0 checks, 107 lines checked d02f5463e184 drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex d3cbebb877f1 drm/i915: Pull all the reset functionality together into i915_reset.c -:1125: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #1125: new file mode 100644 -:1130: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1130: FILE: drivers/gpu/drm/i915/i915_reset.c:1: +/* -:1274: WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'? #1274: FILE: drivers/gpu/drm/i915/i915_reset.c:145: + /* Assert reset for at least 20 usec, and wait for acknowledgement. */ -:1934: WARNING:MEMORY_BARRIER: memory barrier without comment #1934: FILE: drivers/gpu/drm/i915/i915_reset.c:805: + smp_mb__before_atomic(); -:2259: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects? #2259: FILE: drivers/gpu/drm/i915/i915_reset.c:1130: +#define i915_wedge_on_timeout(W, DEV, TIMEOUT) \ + for (__init_wedge((W), (DEV), (TIMEOUT), __func__); \ + (W)->i915; \ + __fini_wedge((W))) -:2270: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2270: FILE: drivers/gpu/drm/i915/i915_reset.c:1141: + char *error_event[] = { I915_ERROR_UEVENT "=1", NULL }; -:2271: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2271: FILE: drivers/gpu/drm/i915/i915_reset.c:1142: + char *reset_event[] = { I915_RESET_UEVENT "=1", NULL }; -:2272: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2272: FILE: drivers/gpu/drm/i915/i915_reset.c:1143: + char *reset_done_event[] = { I915_ERROR_UEVENT "=0", NULL }; -:2468: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #2468: FILE: drivers/gpu/drm/i915/i915_reset.h:1: +/* total: 0 errors, 8 warnings, 1 checks, 2963 lines checked 130d06e20fbd drm/i915: Make all GPU resets atomic -:23: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #23: FILE: drivers/gpu/drm/i915/i915_reset.c:147: + udelay(50); -:29: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #29: FILE: drivers/gpu/drm/i915/i915_reset.c:152: + udelay(50); total: 0 errors, 0 warnings, 2 checks, 111 lines checked a93118d89924 drm/i915: Introduce the i915_user_extension_method -:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 -:62: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #62: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:105: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #105: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:139: WARNING:TYPO_SPELLING: 'compatibilty' may be misspelled - perhaps 'compatibility'? #139: FILE: include/uapi/drm/i915_drm.h:71: + * and backward compatibilty, is to use a list of optional structs to total: 0 errors, 4 warnings, 0 checks, 90 lines checked 4adc1d3b2073 drm/i915: Extend CREATE_CONTEXT to allow inheritance ala clone() -:364: WARNING:LINE_SPACING: Missing a blank line after declarations #364: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:544: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:448: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #448: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:613: + ncontexts = dw = 0; -:567: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #567: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:732: + ncontexts = dw = 0; -:676: WARNING:LONG_LINE: line over 100 characters #676: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) -:676: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #676: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) -:676: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #676: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) total: 1 errors, 3 warnings, 2 checks, 591 lines checked 3649c8fb7536 drm/i915: Allow contexts to share a single timeline across all engines 61e7a8b16c14 drm/i915: Fix I915_EXEC_RING_MASK 6f508694daf5 drm/i915: Re-arrange execbuf so context is known before engine 20ccfc746d06 drm/i915: Allow a context to define its set of engines 6492191779dd drm/i915/execlists: Flush the CS events before unpinning -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: References: 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints") -:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints")' #14: References: 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints") total: 1 errors, 1 warnings, 0 checks, 70 lines checked e43ea3fafed3 drm/i915/execlists: Refactor out can_merge_rq() 6e322a6b0558 drm/i915: Load balancing across a virtual engine _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
