== Series Details == Series: drm/i915/gen11: Implement planar format support. URL : https://patchwork.freedesktop.org/series/49910/ State : warning == Summary == $ dim checkpatch origin/drm-tip a4eaf927a004 drm/i915: Clean up casts to crtc_state in intel_atomic_commit_tail() 0fd609b3d9b6 drm/i915: Handle cursor updating active_planes correctly. ce778e3b4ca8 drm/i915: Make intel_crtc_disable_planes() use active planes mask. -:25: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #25: FILE: drivers/gpu/drm/i915/intel_display.c:5405: +static void intel_crtc_disable_planes(struct intel_crtc *crtc, unsigned plane_mask) -:33: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #33: FILE: drivers/gpu/drm/i915/intel_display.c:5409: + unsigned fb_bits = 0; total: 0 errors, 2 warnings, 0 checks, 45 lines checked 16a4dc462ded drm/i915: Replace call to commit_planes_on_crtc with internal update, v2. 2bf67e55f211 drm/i915: Clean up scaler setup. -:96: CHECK:LINE_SPACING: Please don't use multiple blank lines #96: FILE: drivers/gpu/drm/i915/intel_atomic.c:261: + + total: 0 errors, 0 warnings, 1 checks, 156 lines checked d79e4ec625b1 drm/i915: Force NV12 coordinates to be a multiple of 2 b7730c8c44ca drm/i915: Unconditionally clear plane_state->visible flag 59f05301361b drm/i915/gen11: Enable 6 sprites on gen11 36eaf29d48e4 drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v2. -:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: - Put all the state updating login in intel_plane_atomic_check_with_state(). -:73: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #73: FILE: drivers/gpu/drm/i915/intel_atomic_plane.c:158: + struct intel_crtc *crtc = to_intel_crtc( -:85: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #85: FILE: drivers/gpu/drm/i915/intel_atomic_plane.c:170: + /* + * Make sure a previously linked plane (and implicitly, the CRTC) -:269: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #269: FILE: drivers/gpu/drm/i915/intel_drv.h:560: + bool slave; -:290: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #290: FILE: drivers/gpu/drm/i915/intel_drv.h:1358: +intel_atomic_get_plane_state(struct intel_atomic_state *state, + struct intel_plane *plane) total: 0 errors, 2 warnings, 3 checks, 311 lines checked 7dfbc98f126e drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes. -:90: WARNING:LINE_SPACING: Missing a blank line after declarations #90: FILE: drivers/gpu/drm/i915/intel_pm.c:4319: + enum plane_id aux = plane_state->linked_plane->id; + minimum[aux] = skl_ddb_min_alloc(pstate, 0); total: 0 errors, 1 warnings, 0 checks, 213 lines checked ec1e8d42067e drm/i915: Move programming plane scaler to its own function. -:66: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV) #66: FILE: drivers/gpu/drm/i915/intel_sprite.c:331: + ((crtc_w + 1) << 16)|(crtc_h + 1)); ^ total: 0 errors, 0 warnings, 1 checks, 120 lines checked 33fed8c42f7c drm/i915/gen11: Program the scalers correctly for planar formats. -:45: CHECK:BRACES: Unbalanced braces around else statement #45: FILE: drivers/gpu/drm/i915/intel_atomic.c:242: + } else total: 0 errors, 0 warnings, 1 checks, 122 lines checked e308838371e3 drm/i915/gen11: Program the chroma upsampler for HDR planes. -:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #46: FILE: drivers/gpu/drm/i915/i915_reg.h:6719: +#define PLANE_CUS_CTL(pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CUS_CTL_1(pipe), _PLANE_CUS_CTL_2(pipe)) total: 0 errors, 0 warnings, 1 checks, 68 lines checked 64f5cc32aebb drm/i915/gen11: Program the Y and UV plane for planar mode correctly. 2f4cfd3509d5 drm/i915/gen11: Expose planar format support on gen11. -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 28 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
