Re: [PATCH 3/3] drm/i915/execlists: Reset CSB pointers on canceling requests (wedging)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> The prior assumption was that we did not need to reset the CSB on
> wedging when cancelling the outstanding requests as it would be cleaned
> up in the subsequent reset prior to restarting the GPU. However, what
> was not accounted for was that in performing the reset, we would try to

'performing the reset' could be 'preparing engine for reset'

> process the outstanding CSB entries. If the GPU happened to complete a
> CS event just as we were performing the cancellation of requests, that
> event would be kept in the CSB until the reset -- but our bookkeeping
> was cleared, causing confusion when trying to complete the CS event.
>
> v2: Use a sanitize on unwedge to avoid interfering with eio suspend
> (where we intentionally disable GPU reset).
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107925
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

I was glad to notice that there were quality comments
on resetting/clearing the csb/ports.

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux