Re: [igt-dev] [PATCH i-g-t 1/2] lib: Require drmModeResources()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-09-13 at 14:24 +0100, Chris Wilson wrote:
> If modesetting is not supported, the drmModeGetResources() call will
> fail with -EINVAL (or -ENOTSUPP). As no displays are connected, skip.

This one sounds better than the second patch to me.
I just sent this patch together with other patch skiping the tests not
handled by this one.

Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>

> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
>  lib/igt_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 3e0a07b98..0e6f91475 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1857,7 +1857,7 @@ void igt_display_init(igt_display_t *display,
> int drm_fd)
>  	display->drm_fd = drm_fd;
>  
>  	resources = drmModeGetResources(display->drm_fd);
> -	igt_assert(resources);
> +	igt_require(resources);
>  
>  	/*
>  	 * We cache the number of pipes, that number is a physical
> limit of the
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux