Re: [PATCH] drm/i915: Remove fb pitch limit for no display

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ville Syrjälä (2018-09-13 11:56:56)
> On Thu, Sep 13, 2018 at 11:39:23AM +0100, Chris Wilson wrote:
> > If there is not a display (and so no CRTCs) then there is no upper limit
> > to the framebuffer pitch imposed by the CRTC.
> 
> Should we still allow you to create framebuffers in that case?

Up to you, imho is that fb are just bo with a bit of description. I
didn't see much harm in creating an fb even if it was never going to be
attached to any pipe. I don't have a solid usecase, just feels like it
reduces the impact on the API.

Hmm, however if we
	if (num_pipes == 0) driver_features &= ~DRIVER_MODESET;
we will kill the unusable API at the ioctl boundary.

> If yes then my plan to also query the planes which pixel formats/modifiers
> to accept in addfb is going to hit hard times.

Spreading an ugly if !plane around :(
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux