>-----Original Message----- >From: Wajdeczko, Michal >Sent: Monday, September 10, 2018 3:42 AM >To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Wajdeczko, Michal <Michal.Wajdeczko@xxxxxxxxx>; Spotswood, John A ><john.a.spotswood@xxxxxxxxx>; Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>; >Lis, Tomasz <tomasz.lis@xxxxxxxxx>; Ceraolo Spurio, Daniele ><daniele.ceraolospurio@xxxxxxxxx> >Subject: [CI v2 1/2] drm/i915/guc: Update GuC power domain states > >We should update GuC power domain states also when GuC submission is >disabled, otherwise GuC might complain or ignore our requests. >This seems to be required for all currently released GuC firmwares. > >v2: it is only needed by pre-Gen11 firmwares > >Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> >Cc: John Spotswood <john.a.spotswood@xxxxxxxxx> >Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> >Cc: Tomasz Lis <tomasz.lis@xxxxxxxxx> >Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> Reviewed-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> >--- > drivers/gpu/drm/i915/intel_uc.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c >index 7c95697..b1b3e81 100644 >--- a/drivers/gpu/drm/i915/intel_uc.c >+++ b/drivers/gpu/drm/i915/intel_uc.c >@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915) > ret = intel_guc_submission_enable(guc); > if (ret) > goto err_communication; >+ } else if (INTEL_GEN(i915) < 11) { >+ ret = intel_guc_sample_forcewake(guc); >+ if (ret) >+ goto err_communication; > } > > dev_info(i915->drm.dev, "GuC firmware version %u.%u\n", >-- >1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx