Re: [igt-dev] [PATCH i-g-t] lib: Cancel all outstanding requests at the end of a test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Antonio Argenziano (2018-09-07 17:37:45)
> 
> 
> On 07/09/18 01:41, Chris Wilson wrote:
> > Quite often on catastrophic failure the test leaves a long queue of
> > unterminated batches pending execution. Each runs until hangcheck fires
> > and skips onto the next, leaving us waiting for a very long time at test
> > exit.
> > 
> > On older kernels, this gracefully degrades into the existing mechanism.
> > 
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> 
> LGTM. Just, if I have to be really picky, the comment for 
> quiescent_gpu() says it is installed as an exit handler.

It's still correct in spirit. But no caller of quiescent_gpu() cares
because they need it for idling right there and then.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux