Quoting Michal Wajdeczko (2018-08-29 22:10:38) > Gen11 GuC boot parameter definitions are different than previously > used for Gen9. Try to support both definitions until new firmwares > for pre-Gen11 will be available. This is exactly the kind of branching we want to avoid. Purpose of the GuC is to hide per-Gen differences, not to cause them :) The new interface code should just be GuC interface code (not refer to ICL or any generation specifically), then pre-Gen11 platforms just won't have a drm-tip compatible firmware until -- well -- they do have it. So for the series, just axe the old interface and replace it in-place. Makes the review of the interface differences much more effective, too. Regards, Joonas _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx