On Wed, Sep 5, 2018 at 7:12 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Wed, Sep 05, 2018 at 03:57:06PM +0200, Daniel Vetter wrote: >> Only needed minimal changes in drm_internal.h (for the drm_ioctl_t >> type and a few forward declarations), plus a few missing includes in >> drm_connector.c. >> >> Yay, the last stage of the drm header cleanup can finally commence! >> >> v2: Compiles now, with drm/kernel.h extracted. > 1) It is now named drm_util.h (the drm_util name makes more sense to me) Ah right, I'll fix up when applying or respinning, whichever comes first. > 2) patch revision info belongs outside the changelog part - no? If it's information worth writing it's information worth recording. In drm we're pretty much ok with whatever you feel like, and most people include the patch revision in the commit message. Too many cases where critical information was left out and a patch made no sense at all anymore half a year down the road. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
